From: Bill Gatliff <bgat@billgatliff.com>
To: Mike Frysinger <vapier.adi@gmail.com>
Cc: linux-embedded@vger.kernel.org
Subject: Re: [PWM v5 1/3] PWM: Implement a generic PWM framework
Date: Sun, 20 Feb 2011 18:38:28 -0600 [thread overview]
Message-ID: <AANLkTim3UfTO9u3gL5Nb9Cdsp-qZA7koLBfHbCh=cGmj@mail.gmail.com> (raw)
In-Reply-To: <AANLkTimpo=N8GNZxwkqAWuXqOgvtmqyGcn596rOGSuZv@mail.gmail.com>
Mike:
Thanks for the great feedback and detailed going-over. Will fix all
your points, but have a question:
On Sun, Feb 20, 2011 at 4:46 PM, Mike Frysinger <vapier.adi@gmail.com> wrote:
>> +#ifdef MODULE
>> +module_init(pwm_init);
>> +module_exit(pwm_exit);
>> +MODULE_LICENSE("GPL");
>> +#else
>> +postcore_initcall(pwm_init);
>> +#endif
>
> i dont think you need this MODULE trickery. common code already takes
> care of this for you, and it'd let you avoid a warning about pwm_exit
> being unused.
So the postcore_initcall() becomes equivalent to module_init() when I
build as a module? That would make sense, but I had never thought
about it before now...
b.g.
--
Bill Gatliff
bgat@billgatliff.com
next prev parent reply other threads:[~2011-02-21 0:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-20 4:10 [PWM v5 0/3] Implement a generic PWM framework Bill Gatliff
2011-02-20 4:10 ` [PWM v5 1/3] PWM: " Bill Gatliff
2011-02-20 22:46 ` Mike Frysinger
2011-02-21 0:38 ` Bill Gatliff [this message]
2011-02-21 0:58 ` Mike Frysinger
2011-02-21 3:18 ` Bill Gatliff
2011-02-21 3:33 ` Mike Frysinger
2011-02-21 4:42 ` Bill Gatliff
2011-02-20 4:10 ` [PWM v5 2/3] PWM: GPIO+hrtimer device emulation Bill Gatliff
2011-02-20 22:35 ` Mike Frysinger
2011-02-21 0:39 ` Bill Gatliff
2011-02-20 4:10 ` [PWM v5 3/3] PWM: Atmel PWMC driver Bill Gatliff
2011-02-20 22:31 ` Mike Frysinger
2011-02-21 0:40 ` Bill Gatliff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTim3UfTO9u3gL5Nb9Cdsp-qZA7koLBfHbCh=cGmj@mail.gmail.com' \
--to=bgat@billgatliff.com \
--cc=linux-embedded@vger.kernel.org \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).