* commit 432dc821 breaks machines
@ 2010-10-27 6:52 Guennadi Liakhovetski
2010-10-27 8:31 ` David Woodhouse
2010-10-27 16:18 ` H Hartley Sweeten
0 siblings, 2 replies; 3+ messages in thread
From: Guennadi Liakhovetski @ 2010-10-27 6:52 UTC (permalink / raw)
To: linux-mtd; +Cc: H Hartley Sweeten, linux-embedded
Hi
commit 432dc821c90114f9b0e00f6752a700e937516ade
Author: H Hartley Sweeten <hartleys@visionengravers.com>
Date: Thu Aug 19 18:18:21 2010 -0700
mtd: cleanup Kconfig dependencies
breaks machines by undefining macros like CONFIG_MTD_MAP_BANK_WIDTH_*.
Previously the Kconfig entries like
config MTD_MAP_BANK_WIDTH_1
bool "Support 8-bit buswidth" if MTD_CFI_GEOMETRY
default y
meant, that if MTD_CFI_GEOMETRY is not selected, this config entry is not
_displayed_, and default selections are used. Now, with that "if" removed
and all these Kconfig entries put under a common
if MTD_CFI_GEOMETRY
none of these options get selected by default. Please, revert or otherwise
fix this part.
Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: commit 432dc821 breaks machines
2010-10-27 6:52 commit 432dc821 breaks machines Guennadi Liakhovetski
@ 2010-10-27 8:31 ` David Woodhouse
2010-10-27 16:18 ` H Hartley Sweeten
1 sibling, 0 replies; 3+ messages in thread
From: David Woodhouse @ 2010-10-27 8:31 UTC (permalink / raw)
To: Guennadi Liakhovetski; +Cc: linux-mtd, H Hartley Sweeten, linux-embedded
On Wed, 27 Oct 2010, Guennadi Liakhovetski wrote:
> Hi
>
> commit 432dc821c90114f9b0e00f6752a700e937516ade
> Author: H Hartley Sweeten <hartleys@visionengravers.com>
> Date: Thu Aug 19 18:18:21 2010 -0700
>
> mtd: cleanup Kconfig dependencies
>
> breaks machines by undefining macros like CONFIG_MTD_MAP_BANK_WIDTH_*.
Thanks. This should be fixed in today's linux-next.
--
dwmw2
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: commit 432dc821 breaks machines
2010-10-27 6:52 commit 432dc821 breaks machines Guennadi Liakhovetski
2010-10-27 8:31 ` David Woodhouse
@ 2010-10-27 16:18 ` H Hartley Sweeten
1 sibling, 0 replies; 3+ messages in thread
From: H Hartley Sweeten @ 2010-10-27 16:18 UTC (permalink / raw)
To: Guennadi Liakhovetski, linux-mtd@lists.infradead.org; +Cc: linux-embedded
On Tuesday, October 26, 2010 11:52 PM, Guennadi Liakhovetski wrote:
>
> Hi
>
> commit 432dc821c90114f9b0e00f6752a700e937516ade
> Author: H Hartley Sweeten <hartleys@visionengravers.com>
> Date: Thu Aug 19 18:18:21 2010 -0700
>
> mtd: cleanup Kconfig dependencies
>
> breaks machines by undefining macros like CONFIG_MTD_MAP_BANK_WIDTH_*.
> Previously the Kconfig entries like
>
> config MTD_MAP_BANK_WIDTH_1
> bool "Support 8-bit buswidth" if MTD_CFI_GEOMETRY
> default y
>
> meant, that if MTD_CFI_GEOMETRY is not selected, this config entry is not
> _displayed_, and default selections are used. Now, with that "if" removed
> and all these Kconfig entries put under a common
Yah, I overlooked that part.
>
> if MTD_CFI_GEOMETRY
>
> none of these options get selected by default. Please, revert or otherwise
> fix this part.
I believe David Woodhouse has already reverted the commit.
Sorry for the trouble,
Hartley
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-10-27 16:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-27 6:52 commit 432dc821 breaks machines Guennadi Liakhovetski
2010-10-27 8:31 ` David Woodhouse
2010-10-27 16:18 ` H Hartley Sweeten
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).