From mboxrd@z Thu Jan 1 00:00:00 1970 From: Petr Mladek via iommu Subject: Re: [PATCH 3/3] lib/vsprintf: Use pr_crit() instead of long fancy messages Date: Thu, 20 May 2021 14:51:50 +0200 Message-ID: References: <20210331093104.383705-1-geert+renesas@glider.be> <20210331093104.383705-4-geert+renesas@glider.be> Reply-To: Petr Mladek Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1621515111; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VbT6WFYy0bkSk8HAYhg7anUqtgOM3QEr3KjCoKwSfHQ=; b=gOKAeXWpE3pQwkKpXwPHYoc4ERb31lQ3gBN7nTVt1yldwdnn1/3/XyAFth9rfgDimJkoQH agqxk+9Aox0SUUfXdjH85VkMEQazH8fYJyaFRs2tPVAJC3VdcHlyCnVzQyWN5LMIv2YHXJ O5RoTQ3j+3gflRxjf1BSBzx8QDoYDOo= Content-Disposition: inline In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Sender: "iommu" To: Geert Uytterhoeven Cc: Marco Elver , Linux Embedded , John Ogness , Linus Torvalds , Randy Dunlap , Rasmus Villemoes , Linux Kernel Mailing List , Steven Rostedt , Sergey Senozhatsky , Linux IOMMU , Ingo Molnar , Geert Uytterhoeven , Andrew Morton , Andy Shevchenko , Will Deacon , Vlastimil Babka On Mon 2021-05-17 08:21:12, Geert Uytterhoeven wrote: > On Wed, Mar 31, 2021 at 11:59 AM Geert Uytterhoeven > wrote: > > While long fancy messages have a higher probability of being seen than > > small messages, they may scroll of the screen fast, if visible at all, > > and may still be missed. In addition, they increase boot time and > > kernel size. > > > > The correct mechanism to increase importance of a kernel message is not > > to draw fancy boxes with more text, but to shout louder, i.e. increase > > the message's reporting level. Making sure the administrator of the > > system is aware of such a message is a system policy, and is the > > responsability of a user-space log daemon. > > > > Fix this by increasing the reporting level from KERN_WARNING to > > KERN_CRIT, and removing irrelevant text and graphics. > > > > This reduces kernel size by ca. 0.5 KiB. > > > > Fixes: 5ead723a20e0447b ("lib/vsprintf: no_hash_pointers prints all addresses as unhashed") > > Signed-off-by: Geert Uytterhoeven > > No comments? > Unlike the cases handled by the other two patches in this series, > this one cannot be configured out. IMHO, the best solution would be to create a generic API for eye-catching messages. I am sure that WARN() is misused on many locations all over the kernel because people just wanted eye-catching message, for example, see https://lore.kernel.org/r/2149df3f542d25ce15d049e81d6188bb7198478c.camel-RPVEmwYF7IOGWTQfUlqXWgC/G2K4zDHf@public.gmane.org It might be a win-win solution. Best Regards, Petr