From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Matt Sealey" Subject: Re: [PATCH/RFC] Add Alternative Log Buffer Support for printk Messages Date: Tue, 25 Nov 2008 13:01:15 -0600 Message-ID: References: <1227638045-12862-1-git-send-email-gerickson@nuovations.com> <20081125135519.038abf23@zod.rchland.ibm.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1873551266==" Return-path: In-Reply-To: <20081125135519.038abf23@zod.rchland.ibm.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Mime-version: 1.0 Sender: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@ozlabs.org Errors-To: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@ozlabs.org To: Josh Boyer Cc: linux-embedded@vger.kernel.org, linuxppc-dev@ozlabs.org, Stefan Roese , Wolfgang Denx , Grant Erickson --===============1873551266== Content-Type: multipart/alternative; boundary="----=_Part_9905_12220231.1227639675360" ------=_Part_9905_12220231.1227639675360 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline On Tue, Nov 25, 2008 at 12:55 PM, Josh Boyer wrote: > On Tue, 25 Nov 2008 12:53:12 -0600 > "Matt Sealey" wrote: > > > Nitpick, really.. shouldn't the logbuffer location(s) be some device tree > > property(ies), perhaps something in the > > /chosen node that U-Boot etc. can then fill out? > > I don't think that's a nitpick. It's a fundamental change in how this > would all work. However, I do think you're generally right. > > Perhaps not /chosen, but maybe something like /rtas or /firmware, etc. > > josh I think the best place is chosen, with things like stdin, stdout etc. - this is where you generally go and dump weird little variables which need to be passed in for early boot. You could consider the log buffer a kind of stdin/out variation. I don't think it needs a whole new device tree node just for two memory locations.. is the support really worth a compatible property, etc. to differentiate between different operating modes? -- Matt Sealey Genesi, Manager, Developer Relations ------=_Part_9905_12220231.1227639675360 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline

On Tue, Nov 25, 2008 at 12:55 PM, Josh Boyer <jwboyer@linux.vnet.ibm.com> wrote:
On Tue, 25 Nov 2008 12:53:12 -0600
"Matt Sealey" <matt@genesi-usa.com> wrote:

> Nitpick, really.. shouldn't the logbuffer location(s) be some device tree
> property(ies), perhaps something in the
> /chosen node that U-Boot etc. can then fill out?

I don't think that's a nitpick.  It's a fundamental change in how this
would all work.  However, I do think you're generally right.

Perhaps not /chosen, but maybe something like /rtas or /firmware, etc.

josh
 
I think the best place is chosen, with things like stdin, stdout etc. - this is where you generally go and dump weird little variables which need to be passed in for early boot. You could consider the log buffer a kind of stdin/out variation.

I don't think it needs a whole new device tree node just for two memory locations.. is the support really worth a compatible property, etc. to differentiate between different operating modes?

--
Matt Sealey <matt@genesi-usa.com>
Genesi, Manager, Developer Relations
------=_Part_9905_12220231.1227639675360-- --===============1873551266== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev --===============1873551266==--