From: Ohad Ben-Cohen <ohad@bencohen.org>
To: David Vrabel <david.vrabel@csr.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Philip Langdale <philipl@overt.org>,
Matt Fleming <matt@console-pimps.org>,
ian@mnementh.co.uk, pierre@ossman.eu,
linux-kernel@vger.kernel.org, linux-embedded@vger.kernel.org,
nico@cam.org, nicolas.ferre@rfo.atmel.com, hskinnemoen@atmel.com,
tony@atomide.com, david-b@pacbell.net, manuel.lauss@gmail.com,
mirq-l@jasper.es, Adrian Hunter <adrian.hunter@nokia.com>,
Madhusudhan <madhu.cr@ti.com>
Subject: Re: [PATCH] sdio: add CD disable support
Date: Fri, 31 Jul 2009 14:10:24 +0300 [thread overview]
Message-ID: <bd5b16740907310410q6860eba1m58e5cf2b771d157b@mail.gmail.com> (raw)
In-Reply-To: <4A719811.4060904@csr.com>
Hi David,
Thank you for your comments.
On Thu, Jul 30, 2009 at 3:54 PM, David Vrabel<david.vrabel@csr.com> wrote:
> Platforms may rely on the card's pull-up and not fit/configure an
> external one. There may need to be a way for host controller drivers to
> say this and prevent the disabling of the card's DAT3 pull-up.
Currently the only way to really disable the CD using this patch is by
setting the disable_cd bit on for a specific controller. We are doing so
for a specific controller to which an embedded sdio device is wired,
on certain boards. This is done using the embedded_sdio's .cccr field,
which is used instead of reading the card's cccr.
So as you correctly noted, card has no say here.
> The first sentence of this comment doesn't make sense.
Fixed;
I'll follow-up with a correction of the patch and will appreciate your review.
Thanks,
Ohad.
prev parent reply other threads:[~2009-07-31 11:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-30 11:54 [PATCH] sdio: add CD disable support Ohad Ben-Cohen
2009-07-30 12:45 ` Matt Fleming
2009-07-30 15:55 ` Ohad Ben-Cohen
2009-07-30 18:50 ` Matt Fleming
2009-07-31 11:16 ` Ohad Ben-Cohen
2009-07-30 12:54 ` David Vrabel
2009-07-31 11:10 ` Ohad Ben-Cohen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd5b16740907310410q6860eba1m58e5cf2b771d157b@mail.gmail.com \
--to=ohad@bencohen.org \
--cc=adrian.hunter@nokia.com \
--cc=akpm@linux-foundation.org \
--cc=david-b@pacbell.net \
--cc=david.vrabel@csr.com \
--cc=hskinnemoen@atmel.com \
--cc=ian@mnementh.co.uk \
--cc=linux-embedded@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=madhu.cr@ti.com \
--cc=manuel.lauss@gmail.com \
--cc=matt@console-pimps.org \
--cc=mirq-l@jasper.es \
--cc=nico@cam.org \
--cc=nicolas.ferre@rfo.atmel.com \
--cc=philipl@overt.org \
--cc=pierre@ossman.eu \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).