From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Grant Likely" Subject: Re: [PATCH] phylib: add mdio-gpio bus driver (v3) Date: Tue, 28 Oct 2008 08:26:59 -0600 Message-ID: References: <20081028103537.28951.4804.stgit@Programuotojas.82-135-208-232.ip.zebra.lt> <8bd0f97a0810280350j385a0239if7a33928f7bb11f1@mail.gmail.com> <4906F817.4050306@teltonika.lt> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4906F817.4050306@teltonika.lt> Content-Disposition: inline Sender: netdev-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Paulius Zaleckas Cc: Mike Frysinger , netdev@vger.kernel.org, linux-arm-kernel@lists.arm.linux.org.uk, linux-embedded@vger.kernel.org On Tue, Oct 28, 2008 at 5:31 AM, Paulius Zaleckas wrote: > Mike Frysinger wrote: >> On Tue, Oct 28, 2008 at 06:35, Paulius Zaleckas wrote: >>> +config MDIO_GPIO >>> + tristate "Support for GPIO bitbanged MDIO buses" >>> config MDIO_OF_GPIO >>> tristate "Support for GPIO lib-based bitbanged MDIO buses" >> >> seems to me these drivers have the same description ... > > Yes... but it is MDIO_OF_GPIO description that needs changing... > Should I make patch for it? Wait a minute.... This is the same driver and it's just been duplicated. NAK. Please don't do this. Instead add a platform bus binding to the existing driver. Most of the code can be shared. Cheers, g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd.