From: "Grant Likely" <grant.likely@secretlab.ca>
To: Paulius Zaleckas <paulius.zaleckas@teltonika.lt>
Cc: Mike Frysinger <vapier.adi@gmail.com>,
netdev@vger.kernel.org, linux-arm-kernel@lists.arm.linux.org.uk,
linux-embedded@vger.kernel.org
Subject: Re: [PATCH] phylib: add mdio-gpio bus driver (v3)
Date: Wed, 29 Oct 2008 07:24:04 -0600 [thread overview]
Message-ID: <fa686aa40810290624h272b9095hd56414c433ef832a@mail.gmail.com> (raw)
In-Reply-To: <49082264.7060302@teltonika.lt>
On Wed, Oct 29, 2008 at 2:44 AM, Paulius Zaleckas
<paulius.zaleckas@teltonika.lt> wrote:
> Grant Likely wrote:
>> On Tue, Oct 28, 2008 at 5:31 AM, Paulius Zaleckas
>> <paulius.zaleckas@teltonika.lt> wrote:
>>> Mike Frysinger wrote:
>>>> On Tue, Oct 28, 2008 at 06:35, Paulius Zaleckas wrote:
>>>>> +config MDIO_GPIO
>>>>> + tristate "Support for GPIO bitbanged MDIO buses"
>>>>> config MDIO_OF_GPIO
>>>>> tristate "Support for GPIO lib-based bitbanged MDIO buses"
>>>> seems to me these drivers have the same description ...
>>> Yes... but it is MDIO_OF_GPIO description that needs changing...
>>> Should I make patch for it?
>>
>> Wait a minute.... This is the same driver and it's just been
>> duplicated. NAK. Please don't do this. Instead add a platform bus
>> binding to the existing driver. Most of the code can be shared.
>
> It is very similar. If highly #ifdef'ed driver is OK then I can merge
> these driver to single one, but mdio-ofgpio driver name will have to
> change to mdio-gpio. OK?
Absolutely, change the name. Also, I don't think you'll need as many
#ifdefs as you fear you do. :-) Mostly you'll need two #ifdef
sections; one for the of_platform binding and one for the platform
binding. drivers/video/xilinxfb.c is a good example of how to do it.
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
prev parent reply other threads:[~2008-10-29 13:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-28 10:35 [PATCH] phylib: add mdio-gpio bus driver (v3) Paulius Zaleckas
2008-10-28 10:50 ` Mike Frysinger
2008-10-28 11:31 ` Paulius Zaleckas
2008-10-28 14:26 ` Grant Likely
2008-10-29 8:44 ` Paulius Zaleckas
2008-10-29 13:24 ` Grant Likely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa40810290624h272b9095hd56414c433ef832a@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-embedded@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paulius.zaleckas@teltonika.lt \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).