From: "Grant Likely" <grant.likely@secretlab.ca>
To: Marc Pignat <marc.pignat@hevs.ch>
Cc: Paulius Zaleckas <paulius.zaleckas@teltonika.lt>,
netdev@vger.kernel.org, linux-arm-kernel@lists.arm.linux.org.uk,
linux-embedded@vger.kernel.org,
Laurent Pinchart <laurentp@cse-semaphore.com>,
Mike Frysinger <vapier.adi@gmail.com>
Subject: Re: [PATCH] phylib: make mdio-gpio work without OF (v2)
Date: Tue, 4 Nov 2008 08:57:23 -0700 [thread overview]
Message-ID: <fa686aa40811040757m4e36699nf7870258929ed768@mail.gmail.com> (raw)
In-Reply-To: <200811041645.39953.marc.pignat@hevs.ch>
On Tue, Nov 4, 2008 at 8:45 AM, Marc Pignat <marc.pignat@hevs.ch> wrote:
> Hiü
>
> On Tuesday 04 November 2008, Paulius Zaleckas wrote:
>> make mdio-gpio work with non OpenFirmware gpio implementation.
>
> of_gpio.c provides generic gpio compatible gpios.
>
> Why not remove all OF specific code from this file and add another one
> creating the struct mdio_gpio_platform_data using OF specific functions?
This is a very simple driver. There is no need to split it into two
files. Have two sections of bus binding (OF and non-OF) is just fine.
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
next prev parent reply other threads:[~2008-11-04 15:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-04 14:45 [PATCH] phylib: make mdio-gpio work without OF (v2) Paulius Zaleckas
2008-11-04 15:45 ` Marc Pignat
2008-11-04 15:57 ` Grant Likely [this message]
2008-11-04 16:24 ` Grant Likely
2008-11-05 0:04 ` David Brownell
2008-11-05 0:09 ` Mike Frysinger
2008-11-05 4:45 ` David Brownell
2008-11-05 5:34 ` Mike Frysinger
2008-11-05 8:11 ` David Brownell
2008-11-05 8:32 ` Mike Frysinger
2008-11-05 8:57 ` Marc Pignat
2008-11-05 23:03 ` David Brownell
2008-11-05 8:57 ` Paulius Zaleckas
2008-11-05 9:04 ` Paulius Zaleckas
2008-11-05 15:04 ` Grant Likely
2008-11-05 22:59 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa40811040757m4e36699nf7870258929ed768@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=laurentp@cse-semaphore.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-embedded@vger.kernel.org \
--cc=marc.pignat@hevs.ch \
--cc=netdev@vger.kernel.org \
--cc=paulius.zaleckas@teltonika.lt \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).