From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Grant Likely" Subject: Re: [PATCH] phylib: make mdio-gpio work without OF (v2) Date: Tue, 4 Nov 2008 08:57:23 -0700 Message-ID: References: <20081104144518.4429.37325.stgit@Programuotojas.82-135-208-232.ip.zebra.lt> <200811041645.39953.marc.pignat@hevs.ch> Mime-Version: 1.0 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <200811041645.39953.marc.pignat@hevs.ch> Content-Disposition: inline Sender: linux-embedded-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="iso-8859-1" To: Marc Pignat Cc: Paulius Zaleckas , netdev@vger.kernel.org, linux-arm-kernel@lists.arm.linux.org.uk, linux-embedded@vger.kernel.org, Laurent Pinchart , Mike Frysinger On Tue, Nov 4, 2008 at 8:45 AM, Marc Pignat wrote= : > Hi=FC > > On Tuesday 04 November 2008, Paulius Zaleckas wrote: >> make mdio-gpio work with non OpenFirmware gpio implementation. > > of_gpio.c provides generic gpio compatible gpios. > > Why not remove all OF specific code from this file and add another on= e > creating the struct mdio_gpio_platform_data using OF specific functio= ns? This is a very simple driver. There is no need to split it into two files. Have two sections of bus binding (OF and non-OF) is just fine. g. --=20 Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd.