From mboxrd@z Thu Jan 1 00:00:00 1970 From: chao@kernel.org (Chao Yu) Date: Mon, 19 Aug 2019 22:40:51 +0800 Subject: [PATCH 3/6] staging: erofs: add two missing erofs_workgroup_put for corrupted images In-Reply-To: <20190819103426.87579-4-gaoxiang25@huawei.com> References: <20190819080218.GA42231@138> <20190819103426.87579-1-gaoxiang25@huawei.com> <20190819103426.87579-4-gaoxiang25@huawei.com> Message-ID: <0d2a443b-3d06-014f-aa0b-7ca261a2437f@kernel.org> On 2019-8-19 18:34, Gao Xiang wrote: > As reported by erofs-utils fuzzer, these error handling > path will be entered to handle corrupted images. > > Lack of erofs_workgroup_puts will cause unmounting > unsuccessfully. > > Fix these return values to EFSCORRUPTED as well. > > Fixes: 3883a79abd02 ("staging: erofs: introduce VLE decompression support") > Cc: # 4.19+ > Signed-off-by: Gao Xiang Reviewed-by: Chao Yu Thanks, From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46357C3A5A0 for ; Mon, 19 Aug 2019 14:50:01 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E58372070D for ; Mon, 19 Aug 2019 14:50:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="GWF3MfOg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E58372070D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 46BxfZ2TxBzDqCB for ; Tue, 20 Aug 2019 00:49:58 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=kernel.org (client-ip=198.145.29.99; helo=mail.kernel.org; envelope-from=chao@kernel.org; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="GWF3MfOg"; dkim-atps=neutral Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 46BxSB66H4zDqVs for ; Tue, 20 Aug 2019 00:40:58 +1000 (AEST) Received: from [192.168.0.101] (unknown [180.111.132.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6F3D3206C1; Mon, 19 Aug 2019 14:40:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566225655; bh=r3rHMKzGti8fbcfNxPYG44dYD1wPeB1bVCktItPFRgI=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=GWF3MfOgguDhxBe/OCmy1z9a1tpwa32uzDILjN1amLzQvxYZbjsQxjQ7ofmJu5H2z LyM3MRixhD6J100J+sFs8x1NPbdyY5eyEg3nyUON3CaY2Eq5c41E0pa/HmAy9ipg9X 6JXsjZeXOTYGETNZFKa81ZrC7fD+SzG9Uizm8XWc= Subject: Re: [PATCH 3/6] staging: erofs: add two missing erofs_workgroup_put for corrupted images To: Gao Xiang , Chao Yu , Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-fsdevel@vger.kernel.org References: <20190819080218.GA42231@138> <20190819103426.87579-1-gaoxiang25@huawei.com> <20190819103426.87579-4-gaoxiang25@huawei.com> From: Chao Yu Message-ID: <0d2a443b-3d06-014f-aa0b-7ca261a2437f@kernel.org> Date: Mon, 19 Aug 2019 22:40:51 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190819103426.87579-4-gaoxiang25@huawei.com> Content-Type: text/plain; charset="UTF-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: linux-erofs@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development of Linux EROFS file system List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-erofs@lists.ozlabs.org, LKML , stable@vger.kernel.org, weidu.du@huawei.com, Miao Xie Errors-To: linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Sender: "Linux-erofs" Message-ID: <20190819144051.RD_pEQiNbIvdHI3N4rNyE_FpJmgB2pjCu_W-u9LEGYQ@z> On 2019-8-19 18:34, Gao Xiang wrote: > As reported by erofs-utils fuzzer, these error handling > path will be entered to handle corrupted images. > > Lack of erofs_workgroup_puts will cause unmounting > unsuccessfully. > > Fix these return values to EFSCORRUPTED as well. > > Fixes: 3883a79abd02 ("staging: erofs: introduce VLE decompression support") > Cc: # 4.19+ > Signed-off-by: Gao Xiang Reviewed-by: Chao Yu Thanks,