From mboxrd@z Thu Jan 1 00:00:00 1970 From: richard@nod.at (Richard Weinberger) Date: Mon, 19 Aug 2019 19:10:33 +0200 (CEST) Subject: erofs: Question on unused fields in on-disk structs Message-ID: <1323459733.69859.1566234633793.JavaMail.zimbra@nod.at> Hi! struct erofs_super_block has "checksum" and "features" fields, but they are not used in the source. What is the plan for these? Same for i_checksum in erofs_inode_v1 and erofs_inode_v2. At least the "features" field in the super block is something I'd expect to be used. ...such that you can have new filesystem features in future. Thanks, //richard From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61ECBC3A5A0 for ; Mon, 19 Aug 2019 17:10:54 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1CE4C2087E for ; Mon, 19 Aug 2019 17:10:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1CE4C2087E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=nod.at Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 46C0n775SmzDqtN for ; Tue, 20 Aug 2019 03:10:51 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=permerror (mailfrom) smtp.mailfrom=nod.at (client-ip=195.201.40.130; helo=lithops.sigma-star.at; envelope-from=richard@nod.at; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=nod.at Received: from lithops.sigma-star.at (lithops.sigma-star.at [195.201.40.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 46C0mz5smhzDqfb for ; Tue, 20 Aug 2019 03:10:39 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by lithops.sigma-star.at (Postfix) with ESMTP id 4E1CE6083139; Mon, 19 Aug 2019 19:10:34 +0200 (CEST) Received: from lithops.sigma-star.at ([127.0.0.1]) by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 1PQhCAiESOU6; Mon, 19 Aug 2019 19:10:34 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by lithops.sigma-star.at (Postfix) with ESMTP id 0EF46621FCD3; Mon, 19 Aug 2019 19:10:34 +0200 (CEST) Received: from lithops.sigma-star.at ([127.0.0.1]) by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 50KLyhFl0tO2; Mon, 19 Aug 2019 19:10:33 +0200 (CEST) Received: from lithops.sigma-star.at (lithops.sigma-star.at [195.201.40.130]) by lithops.sigma-star.at (Postfix) with ESMTP id D5D506088967; Mon, 19 Aug 2019 19:10:33 +0200 (CEST) Date: Mon, 19 Aug 2019 19:10:33 +0200 (CEST) From: Richard Weinberger To: linux-erofs@lists.ozlabs.org Message-ID: <1323459733.69859.1566234633793.JavaMail.zimbra@nod.at> Subject: erofs: Question on unused fields in on-disk structs MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [195.201.40.130] X-Mailer: Zimbra 8.8.12_GA_3807 (ZimbraWebClient - FF60 (Linux)/8.8.12_GA_3809) Thread-Index: bPOHXV7QxwRTyFuSImcS2EHKU0x0Yw== Thread-Topic: erofs: Question on unused fields in on-disk structs X-BeenThere: linux-erofs@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development of Linux EROFS file system List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fsdevel@vger.kernel.org, linux-kernel Errors-To: linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Sender: "Linux-erofs" Message-ID: <20190819171033.vyK-HYi-v-w4r5lbVUGu6A3LGspOYXxO6KFGlKNvgZs@z> Hi! struct erofs_super_block has "checksum" and "features" fields, but they are not used in the source. What is the plan for these? Same for i_checksum in erofs_inode_v1 and erofs_inode_v2. At least the "features" field in the super block is something I'd expect to be used. ...such that you can have new filesystem features in future. Thanks, //richard