From: Lucas Karpinski <lkarpinski@nvidia.com>
To: lasyaprathipati@gmail.com, linux-erofs@lists.ozlabs.org,
gaoxiang25@kernel.org
Subject: Re: [PATCH v2] erofs-utils: lib: fix potential NULL pointer dereference in docker_config.c
Date: Wed, 18 Mar 2026 10:06:50 -0400 [thread overview]
Message-ID: <1b7a6e1c-e1f2-48cb-a947-7f5c7f949cea@nvidia.com> (raw)
In-Reply-To: <20260316085300.19229-1-lasyaprathipati@gmail.com>
On 2026-03-16 4:53 a.m., lasyaprathipati@gmail.com wrote:
> From: Sri Lasya <lasyaprathipati@gmail.com>
>
> ---
> lib/remotes/docker_config.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/lib/remotes/docker_config.c b/lib/remotes/docker_config.c
> index b346ee8..6401c1b 100644
> --- a/lib/remotes/docker_config.c
> +++ b/lib/remotes/docker_config.c
> @@ -202,8 +202,10 @@ int erofs_docker_config_lookup(const char *registry,
> }
>
> entry = json_object_iter_peek_value(&it);
> - if (!entry)
> + if (!entry) {
> + json_object_iter_next(&it);
> continue;
> + }
> if (json_object_object_get_ex(entry, "auth", &auth_field)) {
> b64 = json_object_get_string(auth_field);
> if (b64 && *b64) {
There's still a tab issue as Gao mentioned in v1. This looks like a diff
from your v1 to your v2 patch. Similarly, you also dropped your
Signed-Off and are now using a From.
Lastly, you submitted another patch just yesterday that includes this
change in addition to other changes. It is very difficult to follow what
you're doing.
next prev parent reply other threads:[~2026-03-18 14:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-16 8:53 [PATCH v2] erofs-utils: lib: fix potential NULL pointer dereference in docker_config.c lasyaprathipati
2026-03-18 13:22 ` Utkal Singh
2026-03-18 14:06 ` Lucas Karpinski [this message]
2026-03-18 14:26 ` Lucas Karpinski
2026-03-18 14:54 ` Gao Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b7a6e1c-e1f2-48cb-a947-7f5c7f949cea@nvidia.com \
--to=lkarpinski@nvidia.com \
--cc=gaoxiang25@kernel.org \
--cc=lasyaprathipati@gmail.com \
--cc=linux-erofs@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox