From: gregkh@linuxfoundation.org (Greg KH)
Subject: [PATCH] staging: erofs: Add braces to do-while statements
Date: Sun, 9 Dec 2018 20:40:29 +0100 [thread overview]
Message-ID: <20181209194029.GA31163@kroah.com> (raw)
In-Reply-To: <f741ac1808f05f2efe6532491e8b1eb6ac74e260.camel@perches.com>
On Sun, Dec 09, 2018@09:27:01AM -0800, Joe Perches wrote:
> On Sun, 2018-12-09@17:20 +0100, Greg KH wrote:
> > On Sun, Dec 09, 2018@04:59:00PM +0100, Thomas Jespersen wrote:
> > > This fixes warning reported by sparse (with -Wsparse-all).
> >
> > Why is sparse warning about this?
>
> Probably because it's the kernel preferred style
> to use single statement
>
> do {
> <foo>;
> } while (<bar>);
>
> over
>
> by about a 20:1 ratio.
Sparse is spitting out coding style complaints now?
next prev parent reply other threads:[~2018-12-09 19:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-09 15:59 [PATCH] staging: erofs: Add braces to do-while statements Thomas Jespersen
2018-12-09 16:20 ` Greg KH
2018-12-09 17:27 ` Joe Perches
2018-12-09 19:40 ` Greg KH [this message]
2018-12-10 0:42 ` Luc Van Oostenryck
2018-12-09 17:30 ` Joe Perches
2018-12-09 21:37 ` Gao Xiang
-- strict thread matches above, loose matches on Subject: below --
2018-12-08 21:07 Thomas Jespersen
2018-12-09 12:50 ` 高翔
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181209194029.GA31163@kroah.com \
--to=gregkh@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox