Linux-EROFS Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: jeremy@azazel.net (Jeremy Sowden)
Subject: [PATCH 0/2] staging: erofs: fixed -Wmissing-prototype warnings.
Date: Tue, 8 Jan 2019 09:08:50 +0000	[thread overview]
Message-ID: <20190108090850.GB20615@azazel.net> (raw)
In-Reply-To: <5b305a6a-b50d-fd27-4675-88cdeffa577b@huawei.com>

On 2019-01-08,@09:46:18 +0800, Gao Xiang wrote:
> On 2019/1/8 2:25, Jeremy Sowden wrote:
> > Fixes for -Wmissing-prototype warnings in the erofs driver.  One
> > group of functions have been made static; for the second, prototypes
> > have been moved to a head
>
> Is -Wmissing-prototypes required for the current linux kernel?
> I cannot see this warning in my personal kernel compilation...
>
> Functions your fix have already been added proper erofs prefix,
> therefore it wouldn't pollute the global namespace:
> z_erofs_vle_work_release
> z_erofs_unzip_lz4
> erofs_try_to_release_workgroup
>
> erofs_workgroup_free_rcu
> z_erofs_map_blocks_iter

There was a request for help to fix these warnings on the
driverdev-devel mailing list last Novemeber (I've also attached the
message):

  http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-November/128432.html

Currently, the flag is only enabled by passing W=1 to make, but since it
is useful, the idea is to fix all the current warnings and enable it in
the main build.

J.
-------------- next part --------------
An embedded message was scrubbed...
From: Borislav Petkov <bp@alien8.de>
Subject: HELP WANTED: Fix -Wmissing-prototypes warnings
Date: Fri, 9 Nov 2018 18:44:10 +0100
Size: 6710
URL: <http://lists.ozlabs.org/pipermail/linux-erofs/attachments/20190108/1c2a4ac1/attachment.mht>

  reply	other threads:[~2019-01-08  9:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-07 18:25 [PATCH 0/2] staging: erofs: fixed -Wmissing-prototype warnings Jeremy Sowden
2019-01-07 18:25 ` [PATCH 1/2] " Jeremy Sowden
2019-01-07 18:25 ` [PATCH 2/2] " Jeremy Sowden
2019-01-08  1:46 ` [PATCH 0/2] " Gao Xiang
2019-01-08  9:08   ` Jeremy Sowden [this message]
2019-01-08  9:23     ` Gao Xiang
2019-01-08  6:42 ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190108090850.GB20615@azazel.net \
    --to=jeremy@azazel.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox