From: zbestahu@gmail.com (Yue Hu)
Subject: [PATCH] staging: erofs: remove needless dummy functions of erofs_{get, list}xattr
Date: Fri, 21 Jun 2019 12:08:08 +0800 [thread overview]
Message-ID: <20190621040808.3708-1-zbestahu@gmail.com> (raw)
From: Yue Hu <huyue2@yulong.com>
The two dummy functions of erofs_getxattr()/erofs_listxattr() will never
be used if disable CONFIG_EROFS_FS_XATTR.
Signed-off-by: Yue Hu <huyue2 at yulong.com>
---
drivers/staging/erofs/xattr.h | 13 -------------
1 file changed, 13 deletions(-)
diff --git a/drivers/staging/erofs/xattr.h b/drivers/staging/erofs/xattr.h
index 35ba5ac..2c1e46f 100644
--- a/drivers/staging/erofs/xattr.h
+++ b/drivers/staging/erofs/xattr.h
@@ -72,19 +72,6 @@ static inline const struct xattr_handler *erofs_xattr_handler(unsigned index)
int erofs_getxattr(struct inode *, int, const char *, void *, size_t);
ssize_t erofs_listxattr(struct dentry *, char *, size_t);
-#else
-static int __maybe_unused erofs_getxattr(struct inode *inode, int index,
- const char *name,
- void *buffer, size_t buffer_size)
-{
- return -ENOTSUPP;
-}
-
-static ssize_t __maybe_unused erofs_listxattr(struct dentry *dentry,
- char *buffer, size_t buffer_size)
-{
- return -ENOTSUPP;
-}
#endif
#ifdef CONFIG_EROFS_FS_POSIX_ACL
--
1.9.1
next reply other threads:[~2019-06-21 4:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-21 4:08 Yue Hu [this message]
2019-06-21 5:08 ` [PATCH] staging: erofs: remove needless dummy functions of erofs_{get,list}xattr Gao Xiang
2019-06-21 7:02 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190621040808.3708-1-zbestahu@gmail.com \
--to=zbestahu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox