Linux-EROFS Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: gregkh@linuxfoundation.org (Greg KH)
Subject: [PATCH] staging: erofs: remove needless CONFIG_EROFS_FS_SECURITY
Date: Fri, 21 Jun 2019 09:01:25 +0200	[thread overview]
Message-ID: <20190621070125.GB3029@kroah.com> (raw)
In-Reply-To: <20190620083004.2488-1-zbestahu@gmail.com>

On Thu, Jun 20, 2019@04:30:04PM +0800, Yue Hu wrote:
> From: Yue Hu <huyue2 at yulong.com>
> 
> erofs_xattr_security_handler is already marked __maybe_unused, no need
> to add CONFIG_EROFS_FS_SECURITY condition.
> 
> Signed-off-by: Yue Hu <huyue2 at yulong.com>
> ---
>  drivers/staging/erofs/xattr.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/staging/erofs/xattr.c b/drivers/staging/erofs/xattr.c
> index df40654..06024ac 100644
> --- a/drivers/staging/erofs/xattr.c
> +++ b/drivers/staging/erofs/xattr.c
> @@ -499,13 +499,11 @@ static int erofs_xattr_generic_get(const struct xattr_handler *handler,
>  	.get	= erofs_xattr_generic_get,
>  };
>  
> -#ifdef CONFIG_EROFS_FS_SECURITY
>  const struct xattr_handler __maybe_unused erofs_xattr_security_handler = {
>  	.prefix	= XATTR_SECURITY_PREFIX,
>  	.flags	= EROFS_XATTR_INDEX_SECURITY,
>  	.get	= erofs_xattr_generic_get,
>  };
> -#endif

It's nicer just to leave this as-is for now, the memory savings isn't
much at all.

thanks,

greg k-h

      parent reply	other threads:[~2019-06-21  7:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-20  8:30 [PATCH] staging: erofs: remove needless CONFIG_EROFS_FS_SECURITY Yue Hu
2019-06-20  8:32 ` Gao Xiang
2019-06-20  9:22   ` Chao Yu
2019-06-20  9:29     ` Yue Hu
2019-06-20  9:52       ` Chao Yu
2019-06-20  9:56         ` Yue Hu
2019-06-20  9:25   ` Yue Hu
2019-06-20  9:39     ` Gao Xiang
2019-06-21  7:01 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190621070125.GB3029@kroah.com \
    --to=gregkh@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox