Linux-EROFS Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: gregkh@linuxfoundation.org (Greg KH)
Subject: [PATCH] staging: erofs: return the error value if fill_inline_data() fails
Date: Wed, 26 Jun 2019 09:43:43 +0800	[thread overview]
Message-ID: <20190626014343.GA16013@kroah.com> (raw)
In-Reply-To: <20190625172912.00002d55.zbestahu@gmail.com>

On Tue, Jun 25, 2019@05:29:12PM +0800, Yue Hu wrote:
> On Tue, 25 Jun 2019 17:19:36 +0800
> Gao Xiang <hsiangkao@aol.com> wrote:
> 
> > On 2019/6/25 ????3:59, Yue Hu Wrote:
> > > From: Yue Hu <huyue2 at yulong.com>
> > > 
> > > We should consider the error returned by fill_inline_data() when filling
> > > last page in fill_inode(). If not getting inode will be successful even
> > > though last page is bad. That is illogical. Also change -EAGAIN to 0 in
> > > fill_inline_data() to stand for successful filling.
> > > 
> > > Signed-off-by: Yue Hu <huyue2 at yulong.com>  
> > 
> > looks good to me, yet I think you need to Cc staging mailing list at
> > least if you want to upstream quickly (including your older patches...)
> > 
> > 
> > Reviewed-by: Gao Xiang <gaoxiang25 at huawei.com>
> > 
> > 
> > (Don't forget to add 'PATCH RESEND' tag at the subject line if you
> > resend these patches.)
> 
> Ok, got it.

Yes, please resend all of these patches as I am not quite sure which
ones are the "latest".

thanks,

greg k-h

      reply	other threads:[~2019-06-26  1:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-25  7:59 [PATCH] staging: erofs: return the error value if fill_inline_data() fails Yue Hu
2019-06-25  9:19 ` Gao Xiang
2019-06-25  9:29   ` Yue Hu
2019-06-26  1:43     ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190626014343.GA16013@kroah.com \
    --to=gregkh@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox