From: pratikshinde320@gmail.com (Pratik Shinde)
Subject: [PATCH] erofs-utils: error handling for incorrect dbg lvl & compression algorithm
Date: Fri, 2 Aug 2019 00:48:09 +0530 [thread overview]
Message-ID: <20190801191809.13675-1-pratikshinde320@gmail.com> (raw)
handling the case of incorrect debug level.
also, an early check for valid compression algorithm.
Signed-off-by: Pratik Shinde <pratikshinde320 at gmail.com>
---
mkfs/main.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/mkfs/main.c b/mkfs/main.c
index fdb65fd..4231d13 100644
--- a/mkfs/main.c
+++ b/mkfs/main.c
@@ -105,10 +105,22 @@ static int mkfs_parse_options_cfg(int argc, char *argv[])
}
}
cfg.c_compr_alg_master = strndup(optarg, i);
+ if (strcmp(cfg.c_compr_alg_master, "lz4")
+ && strcmp(cfg.c_compr_alg_master, "lz4hc")) {
+ erofs_err("invalid compressor algorithm %s",
+ cfg.c_compr_alg_master);
+ return -EINVAL;
+ }
break;
case 'd':
cfg.c_dbg_lvl = parse_num_from_str(optarg);
+ if (cfg.c_dbg_lvl < 0 || cfg.c_dbg_lvl > 9) {
+ fprintf(stderr,
+ "invalid debug level %d\n",
+ cfg.c_dbg_lvl);
+ return -EINVAL;
+ }
break;
case 'E':
--
2.9.3
next reply other threads:[~2019-08-01 19:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-01 19:18 Pratik Shinde [this message]
2019-08-02 2:00 ` [PATCH] erofs-utils: error handling for incorrect dbg lvl & compression algorithm Gao Xiang
[not found] ` <CAGu0czT-HLnhAKQV6OhtgNu83fGDdHKu7+NZK15m-K7md3zVUQ@mail.gmail.com>
2019-08-02 6:14 ` Gao Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190801191809.13675-1-pratikshinde320@gmail.com \
--to=pratikshinde320@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox