From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 257CACA9ED1 for ; Fri, 1 Nov 2019 21:38:46 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D6C202067D for ; Fri, 1 Nov 2019 21:38:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D6C202067D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=fromorbit.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 474bD35JfXzF6mN for ; Sat, 2 Nov 2019 08:38:43 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.helo=mail105.syd.optusnet.com.au (client-ip=211.29.132.249; helo=mail105.syd.optusnet.com.au; envelope-from=david@fromorbit.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=fromorbit.com Received: from mail105.syd.optusnet.com.au (mail105.syd.optusnet.com.au [211.29.132.249]) by lists.ozlabs.org (Postfix) with ESMTP id 474bCv1cfyzF6lM for ; Sat, 2 Nov 2019 08:38:33 +1100 (AEDT) Received: from dread.disaster.area (pa49-180-67-183.pa.nsw.optusnet.com.au [49.180.67.183]) by mail105.syd.optusnet.com.au (Postfix) with ESMTPS id 239EF3A03EA; Sat, 2 Nov 2019 08:38:26 +1100 (AEDT) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1iQech-0006ba-Hr; Sat, 02 Nov 2019 08:38:23 +1100 Date: Sat, 2 Nov 2019 08:38:23 +1100 From: Dave Chinner To: Geert Uytterhoeven Subject: Re: [RFC] errno.h: Provide EFSCORRUPTED for everybody Message-ID: <20191101213823.GW4614@dread.disaster.area> References: <20191031010736.113783-1-Valdis.Kletnieks@vt.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.2 cv=D+Q3ErZj c=1 sm=1 tr=0 a=3wLbm4YUAFX2xaPZIabsgw==:117 a=3wLbm4YUAFX2xaPZIabsgw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=MeAgGD-zjQ4A:10 a=7-415B0cAAAA:8 a=aJW9rHtRmq1v9DlCOwQA:9 a=CjuIK1q_8ugA:10 a=biEYGPWJfzWAr4FL6Ov7:22 X-BeenThere: linux-erofs@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development of Linux EROFS file system List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: driverdevel , Linux-Arch , Valdis Kletnieks , Arnd Bergmann , "Darrick J. Wong" , Greg Kroah-Hartman , Linux Kernel Mailing List , linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org, Andreas Dilger , Jaegeuk Kim , Linux FS Devel , Theodore Ts'o , Gao Xiang , Ext4 Developers List , linux-erofs@lists.ozlabs.org, Jan Kara Errors-To: linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Sender: "Linux-erofs" On Fri, Nov 01, 2019 at 09:57:31PM +0100, Geert Uytterhoeven wrote: > Hi Valdis, > > On Thu, Oct 31, 2019 at 2:11 AM Valdis Kletnieks > wrote: > > Three questions: (a) ACK/NAK on this patch, (b) should it be all in one > > patch, or one to add to errno.h and 6 patches for 6 filesystems?), and > > (c) if one patch, who gets to shepherd it through? > > > > There's currently 6 filesystems that have the same #define. Move it > > into errno.h so it's defined in just one place. > > > > Signed-off-by: Valdis Kletnieks > > Thanks for your patch! > > > --- a/include/uapi/asm-generic/errno.h > > +++ b/include/uapi/asm-generic/errno.h > > @@ -98,6 +98,7 @@ > > #define EINPROGRESS 115 /* Operation now in progress */ > > #define ESTALE 116 /* Stale file handle */ > > #define EUCLEAN 117 /* Structure needs cleaning */ > > +#define EFSCORRUPTED EUCLEAN > > I have two questions: > a) Why not use EUCLEAN everywhere instead? > Having two different names for the same errno complicates grepping. Because: a) EUCLEAN is horrible for code documentation. EFSCORRUPTED describes exactly the error being returned and/or checked for. b) we've used EFSCORRUPTED in XFS since 1993. i.e. it was an official, published error value on Irix, and we've kept it in the linux code for the past ~20 years because of a) c) Userspace programs that include filesystem specific headers have already been exposed to and use EFSCORRUPTED, so we can't remove/change it without breaking userspace. d) EUCLEAN has a convenient userspace string description that is appropriate for filesystem corruption: "Structure needs cleaning" is precisely what needs to happen. Repair of the filesystem (i.e. recovery to a clean state) is what is required to fix the error.... > b) Perhaps both errors should use different values? That horse bolted to userspace years ago - this is just formalising the practice that has spread across multiple linux filesystems from XFS over the past ~10 years.. Cheers, Dave. -- Dave Chinner david@fromorbit.com