From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3252BCA9ECF for ; Tue, 5 Nov 2019 10:05:38 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DC62D2190F for ; Tue, 5 Nov 2019 10:05:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DC62D2190F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 476lfS1tslzF4c9 for ; Tue, 5 Nov 2019 21:05:36 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=suse.cz (client-ip=195.135.220.15; helo=mx1.suse.de; envelope-from=jack@suse.cz; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=suse.cz Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 476lGx0KCmzF35l for ; Tue, 5 Nov 2019 20:48:40 +1100 (AEDT) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id DDAFFB3A6; Tue, 5 Nov 2019 09:48:34 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 242661E4407; Tue, 5 Nov 2019 10:48:30 +0100 (CET) Date: Tue, 5 Nov 2019 10:48:30 +0100 From: Jan Kara To: Mark Salyzyn Subject: Re: [PATCH v15 1/4] Add flags option to get xattr method paired to __vfs_getxattr Message-ID: <20191105094830.GL22379@quack2.suse.cz> References: <20191104215253.141818-1-salyzyn@android.com> <20191104215253.141818-2-salyzyn@android.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191104215253.141818-2-salyzyn@android.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: linux-erofs@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development of Linux EROFS file system List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Latchesar Ionkov , Dave Kleikamp , jfs-discussion@lists.sourceforge.net, Jan Kara , linux-doc@vger.kernel.org, linux-integrity@vger.kernel.org, Greg Kroah-Hartman , Martin Brandenburg , samba-technical@lists.samba.org, Dominique Martinet , Artem Bityutskiy , Adrian Hunter , David Howells , Chris Mason , "David S. Miller" , Andreas Dilger , Eric Paris , Mauro Carvalho Chehab , netdev@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-afs@lists.infradead.org, Mike Marshall , linux-xfs@vger.kernel.org, linux-unionfs@vger.kernel.org, Andreas Gruenbacher , Sage Weil , "Darrick J . Wong" , Richard Weinberger , Mark Fasheh , Eric Biggers , Hugh Dickins , James Morris , Trond Myklebust , cluster-devel@redhat.com, selinux@vger.kernel.org, Benjamin Coddington , Casey Schaufler , v9fs-developer@lists.sourceforge.net, Ilya Dryomov , linux-ext4@vger.kernel.org, Stephen Smalley , linux-mm@kvack.org, Mark Salyzyn , Serge Hallyn , ecryptfs@vger.kernel.org, linux-cifs@vger.kernel.org, Eric Van Hensbergen , linux-erofs@lists.ozlabs.org, Josef Bacik , reiserfs-devel@vger.kernel.org, Miklos Szeredi , Joel Becker , linux-mtd@lists.infradead.org, Phillip Lougher , David Sterba , Jaegeuk Kim , ceph-devel@vger.kernel.org, devel@lists.orangefs.org, Gao Xiang , Mimi Zohar , Paul Moore , linux-nfs@vger.kernel.org, Theodore Ts'o , linux-fsdevel@vger.kernel.org, Joseph Qi , Mathieu Malaterre , kernel-team@android.com, Jonathan Corbet , Jeff Layton , linux-kernel@vger.kernel.org, Tyler Hicks , Steve French , linux-security-module@vger.kernel.org, ocfs2-devel@oss.oracle.com, Jan Kara , Bob Peterson , Tejun Heo , Andrew Morton , David Woodhouse , Anna Schumaker , linux-btrfs@vger.kernel.org, Alexander Viro Errors-To: linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Sender: "Linux-erofs" > @@ -228,11 +228,11 @@ static int afs_xattr_get_yfs(const struct xattr_handler *handler, > break; > case 1: > data = buf; > - dsize = snprintf(buf, sizeof(buf), "%u", yacl->inherit_flag); > + dsize = scnprintf(buf, sizeof(buf), "%u", yacl->inherit_flag); > break; > case 2: > data = buf; > - dsize = snprintf(buf, sizeof(buf), "%u", yacl->num_cleaned); > + dsize = scnprintf(buf, sizeof(buf), "%u", yacl->num_cleaned); > break; > case 3: These scnprintf() changes (and there are more in the patch) probably shouldn't be here... Otherwise the patch still looks good to me :). Honza -- Jan Kara SUSE Labs, CR