From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 776F9C433F5 for ; Tue, 19 Oct 2021 07:39:58 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2A24C60FD9 for ; Tue, 19 Oct 2021 07:39:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2A24C60FD9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4HYQcr6C7Fz3g69 for ; Tue, 19 Oct 2021 18:39:56 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lst.de (client-ip=213.95.11.211; helo=verein.lst.de; envelope-from=hch@lst.de; receiver=) X-Greylist: delayed 577 seconds by postgrey-1.36 at boromir; Tue, 19 Oct 2021 18:33:14 AEDT Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4HYQT640l0z3f32 for ; Tue, 19 Oct 2021 18:33:14 +1100 (AEDT) Received: by verein.lst.de (Postfix, from userid 2407) id C6E1568BFE; Tue, 19 Oct 2021 09:23:26 +0200 (CEST) Date: Tue, 19 Oct 2021 09:23:26 +0200 From: Christoph Hellwig To: "Darrick J. Wong" Subject: Re: [PATCH 06/11] xfs: factor out a xfs_setup_dax helper Message-ID: <20211019072326.GA23171@lst.de> References: <20211018044054.1779424-1-hch@lst.de> <20211018044054.1779424-7-hch@lst.de> <20211018164351.GT24307@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211018164351.GT24307@magnolia> User-Agent: Mutt/1.5.17 (2007-11-01) X-BeenThere: linux-erofs@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development of Linux EROFS file system List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: , linux-xfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, To-header@lst.de, Mike Snitzer , nvdimm@lists.linux.dev, linux-s390@vger.kernel.org, no@lst.de, on@lst.de, virtualization@lists.linux-foundation.org, "input <"@lst.de, dm-devel@redhat.com, linux-fsdevel@vger.kernel.org, Dan Williams , linux-ext4@vger.kernel.org, Ira Weiny , Christoph Hellwig Errors-To: linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Sender: "Linux-erofs" On Mon, Oct 18, 2021 at 09:43:51AM -0700, Darrick J. Wong wrote: > > --- a/fs/xfs/xfs_super.c > > +++ b/fs/xfs/xfs_super.c > > @@ -339,6 +339,32 @@ xfs_buftarg_is_dax( > > bdev_nr_sectors(bt->bt_bdev)); > > } > > > > +static int > > +xfs_setup_dax( > > /me wonders if this should be named xfs_setup_dax_always, since this > doesn't handle the dax=inode mode? Sure, why not. > The only reason I bring that up is that Eric reminded me a while ago > that we don't actually print any kind of EXPERIMENTAL warning for the > auto-detection behavior. Yes, I actually noticed that as well when preparing this series.