From: Jingbo Xu <jefflexu@linux.alibaba.com>
To: xiang@kernel.org, linux-erofs@lists.ozlabs.org
Subject: [PATCH v3 08/11] erofs-utils: lib: add erofs_rebuild_dump_tree() helper
Date: Tue, 22 Aug 2023 17:24:54 +0800 [thread overview]
Message-ID: <20230822092457.114686-9-jefflexu@linux.alibaba.com> (raw)
In-Reply-To: <20230822092457.114686-1-jefflexu@linux.alibaba.com>
Enhance tarerofs_dump_tree() so that it could optionally skip specified
files, usually for whiteout files.
Rename it to erofs_rebuild_dump_tree().
Signed-off-by: Jingbo Xu <jefflexu@linux.alibaba.com>
---
include/erofs/inode.h | 2 +-
include/erofs/internal.h | 1 +
lib/inode.c | 15 +++++++++++----
mkfs/main.c | 2 +-
4 files changed, 14 insertions(+), 6 deletions(-)
diff --git a/include/erofs/inode.h b/include/erofs/inode.h
index 1c602a8..fe9dda2 100644
--- a/include/erofs/inode.h
+++ b/include/erofs/inode.h
@@ -32,7 +32,7 @@ unsigned int erofs_iput(struct erofs_inode *inode);
erofs_nid_t erofs_lookupnid(struct erofs_inode *inode);
struct erofs_dentry *erofs_d_alloc(struct erofs_inode *parent,
const char *name);
-int tarerofs_dump_tree(struct erofs_inode *dir);
+int erofs_rebuild_dump_tree(struct erofs_inode *dir);
int erofs_init_empty_dir(struct erofs_inode *dir);
struct erofs_inode *erofs_new_inode(void);
struct erofs_inode *erofs_mkfs_build_tree_from_path(const char *path);
diff --git a/include/erofs/internal.h b/include/erofs/internal.h
index 455a73a..fa0a240 100644
--- a/include/erofs/internal.h
+++ b/include/erofs/internal.h
@@ -191,6 +191,7 @@ struct erofs_inode {
bool lazy_tailblock;
bool with_tmpfile;
bool opaque;
+ bool drop;
unsigned int xattr_isize;
unsigned int extent_isize;
diff --git a/lib/inode.c b/lib/inode.c
index b967aab..96012e4 100644
--- a/lib/inode.c
+++ b/lib/inode.c
@@ -1323,9 +1323,9 @@ struct erofs_inode *erofs_mkfs_build_special_from_fd(int fd, const char *name)
return inode;
}
-int tarerofs_dump_tree(struct erofs_inode *dir)
+int erofs_rebuild_dump_tree(struct erofs_inode *dir)
{
- struct erofs_dentry *d;
+ struct erofs_dentry *d, *n;
unsigned int nr_subdirs;
int ret;
@@ -1369,8 +1369,15 @@ int tarerofs_dump_tree(struct erofs_inode *dir)
}
nr_subdirs = 0;
- list_for_each_entry(d, &dir->i_subdirs, d_child)
+ list_for_each_entry_safe(d, n, &dir->i_subdirs, d_child) {
+ if (d->inode->drop) {
+ list_del(&d->d_child);
+ erofs_d_invalidate(d);
+ free(d);
+ continue;
+ }
++nr_subdirs;
+ }
ret = erofs_prepare_dir_layout(dir, nr_subdirs);
if (ret)
@@ -1391,7 +1398,7 @@ int tarerofs_dump_tree(struct erofs_inode *dir)
continue;
inode = erofs_igrab(d->inode);
- ret = tarerofs_dump_tree(inode);
+ ret = erofs_rebuild_dump_tree(inode);
dir->i_nlink += (erofs_mode_to_ftype(inode->i_mode) == EROFS_FT_DIR);
erofs_iput(inode);
if (ret)
diff --git a/mkfs/main.c b/mkfs/main.c
index c03a7a8..628af59 100644
--- a/mkfs/main.c
+++ b/mkfs/main.c
@@ -946,7 +946,7 @@ int main(int argc, char **argv)
if (err < 0)
goto exit;
- err = tarerofs_dump_tree(root_inode);
+ err = erofs_rebuild_dump_tree(root_inode);
if (err < 0)
goto exit;
}
--
2.19.1.6.gb485710b
next prev parent reply other threads:[~2023-08-22 9:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-22 9:24 [PATCH v3 00/11] erofs-utils: mkfs: introduce rebuild mode Jingbo Xu
2023-08-22 9:24 ` [PATCH v3 01/11] erofs-utils: lib: fix erofs_init_devices Jingbo Xu
2023-08-22 9:26 ` Jingbo Xu
2023-08-22 9:24 ` [PATCH v3 02/11] erofs-utils: lib: scan devtable if extra_devices is not specified Jingbo Xu
2023-08-23 3:15 ` Gao Xiang
2023-08-22 9:24 ` [PATCH v3 03/11] erofs-utils: lib: fix dirent type of whiteout in tarerofs Jingbo Xu
2023-08-22 9:24 ` [PATCH v3 04/11] erofs-utils: lib: add list_splice_tail() helper Jingbo Xu
2023-08-22 9:24 ` [PATCH v3 05/11] erofs-utils: lib: make erofs_get_unhashed_chunk() global Jingbo Xu
2023-08-22 9:24 ` [PATCH v3 06/11] erofs-utils: lib: add erofs_read_xattrs_from_disk() helper Jingbo Xu
2023-08-22 9:24 ` [PATCH v3 07/11] erofs-utils: lib: add erofs_insert_ihash() helper Jingbo Xu
2023-08-22 9:24 ` Jingbo Xu [this message]
2023-08-22 9:24 ` [PATCH v3 09/11] erofs-utils: lib: add erofs_rebuild_get_dentry() helper Jingbo Xu
2023-08-22 9:24 ` [PATCH v3 10/11] erofs-utils: lib: add erofs_rebuild_load_tree() helper Jingbo Xu
2023-08-22 9:24 ` [PATCH v3 11/11] erofs-utils: mkfs: introduce rebuild mode Jingbo Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230822092457.114686-9-jefflexu@linux.alibaba.com \
--to=jefflexu@linux.alibaba.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=xiang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox