From: Yue Hu <zbestahu@gmail.com>
To: Gao Xiang <hsiangkao@linux.alibaba.com>
Cc: huyue2@coolpad.com, linux-erofs@lists.ozlabs.org
Subject: Re: [PATCH 1/2] erofs-utils: lib: fix up compact indexes for block size < 4096
Date: Thu, 23 Nov 2023 17:11:59 +0800 [thread overview]
Message-ID: <20231123171159.00003646.zbestahu@gmail.com> (raw)
In-Reply-To: <20231123052245.868698-1-hsiangkao@linux.alibaba.com>
On Thu, 23 Nov 2023 13:22:44 +0800
Gao Xiang <hsiangkao@linux.alibaba.com> wrote:
> Previously, the block size always equaled to PAGE_SIZE in kernel,
> therefore `lclusterbits` couldn't be less than 12.
>
> Since sub-page compressed blocks are now considered, `lobits` for
> a lcluster in each pack of compact indexes cannot always be
> `lclusterbits` as before. Otherwise, there is no enough room for
> the special value `Z_EROFS_LI_D0_CBLKCNT`.
>
> To support smaller block sizes, `lobits` for each compacted lcluster is
> now calculated as:
> lobits = max(lclusterbits, ilog2(Z_EROFS_LI_D0_CBLKCNT) + 1)
>
> Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Reviewed-by: Yue Hu <huyue2@coolpad.com>
prev parent reply other threads:[~2023-11-23 9:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-23 5:22 [PATCH 1/2] erofs-utils: lib: fix up compact indexes for block size < 4096 Gao Xiang
2023-11-23 5:22 ` [PATCH 2/2] erofs-utils: mkfs: support compact indexes for smaller block sizes Gao Xiang
2023-11-23 9:12 ` Yue Hu
2023-11-23 9:11 ` Yue Hu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231123171159.00003646.zbestahu@gmail.com \
--to=zbestahu@gmail.com \
--cc=hsiangkao@linux.alibaba.com \
--cc=huyue2@coolpad.com \
--cc=linux-erofs@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox