From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 265F6D37E33 for ; Wed, 14 Jan 2026 13:40:07 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4drnKx5CPvz2xMt; Thu, 15 Jan 2026 00:40:05 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip="2a00:1450:4864:20::42b" ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1768398005; cv=none; b=eVoqlW7SFPzvVBcl/gl1BA+w8IiAFj2V8Zykz5sLQGTLf0inu0j5CovhOkpfz3V1Ka0b9np6b4cyW7Dqh+AZnolilR7mhQdtNHYtpWGG+MSi9vISvB1Relo43bMfBdcAUzTsHjb6Srxoh5sQl2hzia64hT/jGN5FbvSXC+xpFUQBDRSQATpSSftieQubNu+994QnNHhnRlqCeAMJmwlQgA2YKa3TR+qclYg6B4+ncZK4zkk5b1I0igEPibW4AT5BSV/rB+wPd6wKGKEIfsHdbcRlNyId0OUsOZn71JitlbYE6HRLz6UlXrs6ggIOjXuXUgSim8Qa8e8PWlmpjiD84g== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1768398005; c=relaxed/relaxed; bh=5wmwTmp5IFzHOcZYUSrwZ2WCFgEOIoQQbhD/zBC9MXc=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=MKQI4uNwVQxbsyU8RWGBANMx2DqHUAjwzJXRy6pfS9C/f/eGIs7LEJNq9KsyZAI9UokVrGpjfG4PtsKbBG0+xzr/NF390+AqvmM0sMpZ/pX7CVPxIhOAsnMVc6SS9T3PxF7j7vl06sDIfqIsyGCXXbbbNd/PO5S1oZgegL2e/3paNlom3qtFSWVWzrvnkHK0xqdn6K/1b4e5BqgKxxtn0YkUu1LdyW8ACUMJzWpQEApcQMUUGTduIz0FW+XVMEwDGVKiNIZa7gVIWTyNin2WwDkEZJfrDZL1GBiVLuyetqfTJdXwbvflriifNrs1Hk5mYIsB0pXFOQeLnVb+sODEsA== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=XK3UNtbL; dkim-atps=neutral; spf=pass (client-ip=2a00:1450:4864:20::42b; helo=mail-wr1-x42b.google.com; envelope-from=david.laight.linux@gmail.com; receiver=lists.ozlabs.org) smtp.mailfrom=gmail.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=XK3UNtbL; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2a00:1450:4864:20::42b; helo=mail-wr1-x42b.google.com; envelope-from=david.laight.linux@gmail.com; receiver=lists.ozlabs.org) Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4drnKw3qzwz2xMQ for ; Thu, 15 Jan 2026 00:40:04 +1100 (AEDT) Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-430f2ee2f00so5174282f8f.3 for ; Wed, 14 Jan 2026 05:40:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768398001; x=1769002801; darn=lists.ozlabs.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=5wmwTmp5IFzHOcZYUSrwZ2WCFgEOIoQQbhD/zBC9MXc=; b=XK3UNtbLeLOe60355Bt8fhjL1mXV6kdkfvXVHKHeScJ4UaTpG74xJftfFA3jMOksuc ml7GU8jXxp7wsdVmQDVq3H3zg8zBpzoi5udGNR/NIK9aGJIbVc7ua3SackmXhnkCsBTR UYqYinDeI+wYDdiZaifspMCiHabjQAuWaftEzMtMReK7ilsf1qjxmkXZMla3DfBAKVth /GjYluwzv+HFPwo/0LhJROJlYWoA+25YplAu039V0Wdlg4sFNv/mpIRGjsvY9/zgT3TX hoYAP2Vvh/eRE141BCfFttYmh1qrLOQ1A0v7nbb3zfJ0ce5IYAnAZyO71eqPZjEXdpQD DYMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768398001; x=1769002801; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=5wmwTmp5IFzHOcZYUSrwZ2WCFgEOIoQQbhD/zBC9MXc=; b=wXnidbbWEPOjoCT3rj7/yg0jl8lOKmvACNBUcKTmLzmeVHjPGsW3QM7dOiUQeiZPAa KTVuqB7GvSQ+I8wzaeoYowxarbon6fFDdF3Hbk82Sc4qFnBtfH2iZXkjSyMfHeqBJr/u CxZWHXDhBvk/hvj1C2i1+S51WZapxAp3HOG8cMFNX4IDn7t1jHL3gT9Cpx+OUWEHF2x+ 4jx34wOBQ7zXr/A2plyF70YdwJkwIc8LpGwP/2l3bBBvlrYOyQy35rkC5dqIrn0fBiXI U3bRiwKzxnWZxhTeVStJXus+Bi7c1qCPXK55c+LIYqQB4FODuCoHyITvZmDhc5cSCiBU yaew== X-Forwarded-Encrypted: i=1; AJvYcCVf7jEasgYG/Xb/EshreIwxLUPtPvGkuhal+46fd0nZYWnh+HsVkKv4V33wEivTaTVnvv0QDnYiKAn4tw==@lists.ozlabs.org X-Gm-Message-State: AOJu0YzxYpTPQVRg43jrN1JFbDxBHy+M0fuhsbZE/6lKmwY6kZgcvpiG QNZBcLU0dSnuLtkS9qvVz+CP5UnXGogYMO3QduhuWBud4oR9t/A5aDpj X-Gm-Gg: AY/fxX5QdaIKwZHi62um54z6lFAlCSL0GVgwfahjhC77WCahNdCCqzMdAXvD2m95Gqc R35kpK9/DJ7IvlVu3hD59evA26cQaFHoKeE+/SbnVKGw8GbPibeCpthoBAYHd/tI8W9UIyFwNZ5 aF7WAxhUlFPSpsWAe/QutRuTFAU8Xbcchf9B1DpuVGjxU5vx8ZMqn+5VUiEHJcytMb9ovHuxz1s Jo+lSSZa2So6oux0ryN4KY9lLUZwJ+03n6deZoFUUuY93O2RTyT+xjbFtTvjtWNis1qHjzmoYbp ChWAL1e9mfzmFFxmenu9z0wrM7SZCNCF4koU2+U4CYtMe/oBFAGpEpdXT5TLrv7xsFfKokZ3pOe uvv/isu/7gQ42GCmMTbH3oUTWdohlKbvmo91PlLMmxe4jCz2Z/991aBicVjKue9v6+tfWPvuVn6 Tyc10+hlgRMJd0t0HoDjH31rJOafe/GyqrPWjDY+aYwsBjWAWjmFdd X-Received: by 2002:a5d:53c9:0:b0:432:5bf9:cf2e with SMTP id ffacd0b85a97d-4342c3ef274mr2643750f8f.13.1768398001040; Wed, 14 Jan 2026 05:40:01 -0800 (PST) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd5edd51sm50238105f8f.29.2026.01.14.05.39.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jan 2026 05:40:00 -0800 (PST) Date: Wed, 14 Jan 2026 13:39:55 +0000 From: David Laight To: Amir Goldstein Cc: Christoph Hellwig , Jeff Layton , Christian Brauner , Chuck Lever , Jan Kara , Luis de Bethencourt , Salah Triki , Nicolas Pitre , Anders Larsen , Alexander Viro , David Sterba , Chris Mason , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Sandeep Dhavale , Hongbo Li , Chunhai Guo , Jan Kara , "Theodore Ts'o" , Andreas Dilger , Jaegeuk Kim , OGAWA Hirofumi , David Woodhouse , Richard Weinberger , Dave Kleikamp , Ryusuke Konishi , Viacheslav Dubeyko , Konstantin Komarov , Mark Fasheh , Joel Becker , Joseph Qi , Mike Marshall , Martin Brandenburg , Miklos Szeredi , Phillip Lougher , Carlos Maiolino , Hugh Dickins , Baolin Wang , Andrew Morton , Namjae Jeon , Sungjong Seo , Yuezhang Mo , Alexander Aring , Andreas Gruenbacher , Jonathan Corbet , "Matthew Wilcox (Oracle)" , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , Xiubo Li , Ilya Dryomov , Trond Myklebust , Anna Schumaker , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Bharath SM , Hans de Goede , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mtd@lists.infradead.org, jfs-discussion@lists.sourceforge.net, linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, devel@lists.orangefs.org, linux-unionfs@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, gfs2@lists.linux.dev, linux-doc@vger.kernel.org, v9fs@lists.linux.dev, ceph-devel@vger.kernel.org, linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org Subject: Re: [PATCH 00/24] vfs: require filesystems to explicitly opt-in to lease support Message-ID: <20260114133955.0a9f5cd3@pumpkin> In-Reply-To: References: <20260108-setlease-6-20-v1-0-ea4dec9b67fa@kernel.org> <8af369636c32b868f83669c49aea708ca3b894ac.camel@kernel.org> <20260113-mondlicht-raven-82fc4eb70e9d@brauner> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) X-Mailing-List: linux-erofs@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Wed, 14 Jan 2026 10:34:04 +0100 Amir Goldstein wrote: > On Wed, Jan 14, 2026 at 7:28=E2=80=AFAM Christoph Hellwig wrote: > > > > On Tue, Jan 13, 2026 at 12:06:42PM -0500, Jeff Layton wrote: =20 > > > Fair point, but it's not that hard to conceive of a situation where > > > someone inadvertantly exports cgroupfs or some similar filesystem: =20 > > > > Sure. But how is this worse than accidentally exporting private data > > or any other misconfiguration? > > =20 >=20 > My POV is that it is less about security (as your question implies), and > more about correctness. >=20 > The special thing about NFS export, as opposed to, say, ksmbd, is > open by file handle, IOW, the export_operations. >=20 > I perceive this as a very strange and undesired situation when NFS > file handles do not behave as persistent file handles. >=20 > FUSE will gladly open a completely different object, sometimes > a different object type from an NFS client request after server restart. >=20 > I suppose that the same could happen with tmpfs and probably some > other fs. ... You really shouldn't be allowed to nfs export a fs that doesn't have persistent file handles. Even file handles containing 'random' numbers can be problematic. The default used to be 'hard mounts' (not sure it is any more) which caused the client (not Linux - too long ago) to loop in kernel forever waiting for the server to recover the filesystem export. The only resolution on that system was to reboot the client. At least nfs can now use variable size file-ids. When I was fixing some code that exported a layered fs (I pretty much rewrote the fs at the same time) I did randomise the file-ids so they (hopefully) became invalid after a reboot (only after suffering some very corrupt filesystems!) I found nfs (over udp) had some interesting 'features': - If you export part of a fs you export all of it. (Especially since this predated the randomisation of the inode generation number.) - If you give anyone access you give everyone access. - If you give anyone write access you give everyone write access. The latter two because the 'mount' protocol wasn't really needed and the server didn't care where requests came from. David