From: Nithurshen <nithurshen.dev@gmail.com>
To: linux-erofs@lists.ozlabs.org
Cc: xiang@kernel.org, hsiangkao@linux.alibaba.com,
Nithurshen <nithurshen.dev@gmail.com>
Subject: [PATCH 2/2] erofs-utils: fsck: add warning for unsupported file types during extraction
Date: Fri, 6 Mar 2026 14:27:17 +0530 [thread overview]
Message-ID: <20260306085717.12776-3-nithurshen.dev@gmail.com> (raw)
In-Reply-To: <20260306085717.12776-1-nithurshen.dev@gmail.com>
When extracting an image using `fsck.erofs`, if the tool encounters an unsupported file type (falling into the `default` case of the switch statement), it currently skips extraction silently and jumps straight to verifying the data chunk layout.
Add a warning message to the `default` case so the user is explicitly informed that a specific file type was not extracted, rather than failing silently.
Signed-off-by: Nithurshen <nithurshen.dev@gmail.com>
---
fsck/main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fsck/main.c b/fsck/main.c
index 16cc627..16a354f 100644
--- a/fsck/main.c
+++ b/fsck/main.c
@@ -963,7 +963,8 @@ verify:
ret = erofs_extract_special(inode);
break;
default:
- /* TODO */
+ erofs_warn("unsupported file type %o @ nid %llu, skipped extraction",
+ inode->i_mode, inode->nid | 0ULL);
goto verify;
}
if (ret && ret != -ECANCELED)
--
2.51.0
next prev parent reply other threads:[~2026-03-06 8:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-06 8:57 [PATCH 0/2] erofs-utils: minor cleanups and enhancements Nithurshen
2026-03-06 8:57 ` [PATCH 1/2] erofs-utils: dump: remove redundant conditional branch in filesize distribution Nithurshen
2026-03-06 8:57 ` Nithurshen [this message]
2026-03-16 10:05 ` [PATCH 0/2] erofs-utils: minor cleanups and enhancements Gao Xiang
2026-03-16 10:52 ` [PATCH v2 " Nithurshen
2026-03-16 10:52 ` [PATCH v2 1/2] erofs-utils: dump: remove redundant conditional branch in filesize distribution Nithurshen
2026-03-16 10:52 ` [PATCH v2] erofs-utils: mkfs: add --exclude-path-from and --exclude-regex-from Nithurshen
2026-03-16 10:52 ` [PATCH v2] mkfs: support block map for blob devices Nithurshen
2026-03-16 10:52 ` [PATCH v2 2/2] erofs-utils: fsck: add warning for unsupported file types during extraction Nithurshen
2026-03-16 10:59 ` [PATCH v3 0/2] erofs-utils: minor cleanups and enhancements Nithurshen
2026-03-16 10:59 ` [PATCH v3 1/2] erofs-utils: dump: remove redundant conditional branch in filesize distribution Nithurshen
2026-03-16 10:59 ` [PATCH v3 2/2] erofs-utils: fsck: add warning for unsupported file types during extraction Nithurshen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260306085717.12776-3-nithurshen.dev@gmail.com \
--to=nithurshen.dev@gmail.com \
--cc=hsiangkao@linux.alibaba.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=xiang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox