From: Utkal Singh <singhutkal015@gmail.com>
To: hsiangkao@linux.alibaba.com
Cc: linux-erofs@lists.ozlabs.org, Utkal Singh <singhutkal015@gmail.com>
Subject: [PATCH] erofs-utils: lib/tar: fix missing NULL checks after malloc() in tarerofs_read_header()
Date: Mon, 16 Mar 2026 09:11:27 +0000 [thread overview]
Message-ID: <20260316091127.48847-1-singhutkal015@gmail.com> (raw)
In case 'L' and case 'K' of tarerofs_read_header(), malloc() is
called for eh.path and eh.link respectively, but the return value
is not checked before immediately passing the pointer to
erofs_iostream_bread(). On memory allocation failure, this results
in a NULL pointer dereference and crash.
Add NULL checks after each malloc() call and return -ENOMEM on
failure.
Signed-off-by: Utkal Singh <singhutkal015@gmail.com>
---
lib/tar.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/lib/tar.c b/lib/tar.c
index 13e777a..5a6e07d 100644
--- a/lib/tar.c
+++ b/lib/tar.c
@@ -906,6 +906,10 @@ out_eot:
case 'L':
free(eh.path);
eh.path = malloc(st.st_size + 1);
+ if (!eh.path) {
+ ret = -ENOMEM;
+ goto out;
+ }
if (st.st_size != erofs_iostream_bread(&tar->ios, eh.path,
st.st_size))
goto invalid_tar;
@@ -914,6 +918,10 @@ out_eot:
case 'K':
free(eh.link);
eh.link = malloc(st.st_size + 1);
+ if (!eh.link) {
+ ret = -ENOMEM;
+ goto out;
+ }
if (st.st_size > PATH_MAX || st.st_size !=
erofs_iostream_bread(&tar->ios, eh.link, st.st_size))
goto invalid_tar;
--
2.43.0
reply other threads:[~2026-03-16 9:11 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260316091127.48847-1-singhutkal015@gmail.com \
--to=singhutkal015@gmail.com \
--cc=hsiangkao@linux.alibaba.com \
--cc=linux-erofs@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox