From: Nithurshen <nithurshen.dev@gmail.com>
To: ch@vnsh.in
Cc: linux-erofs@lists.ozlabs.org, xiang@kernel.org,
Nithurshen <nithurshen.dev@gmail.com>
Subject: Re: [PATCH] erofs-utils: fsck: fix directory loop tracking
Date: Sat, 21 Mar 2026 21:35:51 +0530 [thread overview]
Message-ID: <20260321160551.20683-1-nithurshen.dev@gmail.com> (raw)
In-Reply-To: <20260321142852.35991-1-ch@vnsh.in>
Hi Xiang,
This patch LGTM.
I tested the fix by compiling fsck with a debug trace and running
it against an image with a nested directory structure. I verified
that the recursion stack now correctly pushes the current directory's
NID (inode.nid) instead of inheriting the parent's NID, successfully
fixing the loop tracking logic.
Reviewed-by: Nithurshen <nithurshen.dev@gmail.com>
Tested-by: Nithurshen <nithurshen.dev@gmail.com>
next prev parent reply other threads:[~2026-03-21 16:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-21 14:28 [PATCH] erofs-utils: fsck: fix directory loop tracking Vansh Choudhary
2026-03-21 16:05 ` Nithurshen [this message]
2026-03-22 0:41 ` Gao Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260321160551.20683-1-nithurshen.dev@gmail.com \
--to=nithurshen.dev@gmail.com \
--cc=ch@vnsh.in \
--cc=linux-erofs@lists.ozlabs.org \
--cc=xiang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox