public inbox for linux-erofs@ozlabs.org
 help / color / mirror / Atom feed
From: Nithurshen <nithurshen.dev@gmail.com>
To: nithurshen.dev@gmail.com
Cc: hsiangkao@linux.alibaba.com, linux-erofs@lists.ozlabs.org,
	singhutkal015@gmail.com, xiang@kernel.org
Subject: Re: [PATCH] fsck: add --workers option to configure worker threads
Date: Sun, 22 Mar 2026 14:27:29 +0530	[thread overview]
Message-ID: <20260322085729.24511-1-nithurshen.dev@gmail.com> (raw)
In-Reply-To: <20260322083620.19933-1-nithurshen.dev@gmail.com>

As you know, currently decompression process in fsck.erofs is currently
strictly single threaded. In fsck/main.c, erofs_verify_inode_data
still processes blocks synchronously via a standard while loop.
Without wiring this flag to the workqueue engine in lib/workqueue.c,
the option doesn't currently change the tool's behavior.

And as you know "Multi-threaded Decompression Support in fsck.erofs"
is actually an official GSoC 2026 project idea and the project will
likely involve a comprehensive design of the parallelized
architecture, landing just the --workers CLI portion now might be
premature or conflict with the eventual design chosen by the GSoC
contributor.

I'd suggest reaching out to the mentors on the list to see if they
want to hold off on this patch until the GSoC project kicks off.
Also, if you do send a v2, switching to strtol() would be safer to
avoid potential -1 wrap-around issues on 32-bit systems.

Best,
Nithurshen


  reply	other threads:[~2026-03-22  8:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-22  6:47 [PATCH] fsck: add --workers option to configure worker threads Utkal Singh
2026-03-22  8:36 ` Nithurshen
2026-03-22  8:57   ` Nithurshen [this message]
2026-03-22  9:31     ` Utkal Singh
2026-03-22  9:48       ` Gao Xiang
2026-03-22 16:23         ` Utkal Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260322085729.24511-1-nithurshen.dev@gmail.com \
    --to=nithurshen.dev@gmail.com \
    --cc=hsiangkao@linux.alibaba.com \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=singhutkal015@gmail.com \
    --cc=xiang@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox