From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C0B0F10A1E64 for ; Thu, 26 Mar 2026 10:49:19 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4fhLB63JfTz2ygp; Thu, 26 Mar 2026 21:49:18 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1774522158; cv=none; b=iaviUDSdpU0kZrSqs/vZpZnp+GBO+ef+RLSupYaRnQTB9vi1DnZTmMEAF/Nw8yp3lAgu11DeNszBGmxNvcEXyPHk02mSPOcuUYFpeKmSCMyru82Dk/4up440OGTVHMaY+Nt0i9KC57EYP0Gt5oluPXrwY60e3gDAAgM+EGMAlwE2CDy1lwaJtY98jVBdmTjyxoG64UcCmpSYwZyrXyHqOqIRAEY9atVYKo2JAbPW1FQfXWF1lhWvEmiwnKEVqIZuhjio2HtpvQwlLzqsiecbe4W2axzU8VqyjHzcBoP18Jaw2Ym9Q9KRmsfu1GMkXnm6aFnL7mH717mg+Ct8/+pvtA== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1774522158; c=relaxed/relaxed; bh=k6WIL/CPxi5yzw8jRwBaVYznmdI4kDLcX63WUAhouhQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:content-type; b=SlKWipP8ABCmCJ/ZgHafHI4L3d8/ktoBm0ndEOz1sJyWzLOvY7cP01+w0XwC+DSYI023SeN04dfEhIHx5v/kNmnZbBqxSe5ZOMv+F1QXZWluXAHBICkATCr5dRjJDYmsdcPqncjpoEdLcsQwuMHHZcYEs1QoGuYOYa9N/0sLt7s6HXK+e7veQGgeJvov10HJX0R8uxHbFGjveEG/S5zLpyaeZt+O16Z0w6z0ComWw4lE0OP3BLivpFSDgJ+S/M8VlMezbgx3hCmQ8POdbpXgfHVME9yAIW6GLNu3NaKBAeulmKbQGqZqF7myufuPUt6JZPqO1qL7ud5OKxdjwO+bAA== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=CJ2rvj9o; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=CJ2rvj9o; dkim-atps=neutral; spf=pass (client-ip=170.10.133.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=dhowells@redhat.com; receiver=lists.ozlabs.org) smtp.mailfrom=redhat.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=CJ2rvj9o; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=CJ2rvj9o; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=redhat.com (client-ip=170.10.133.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=dhowells@redhat.com; receiver=lists.ozlabs.org) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4fhLB54fc5z2xN8 for ; Thu, 26 Mar 2026 21:49:17 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774522154; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=k6WIL/CPxi5yzw8jRwBaVYznmdI4kDLcX63WUAhouhQ=; b=CJ2rvj9oxDxuwbi8Wrk9bGDvwgKoAXTKamKO1AfyzoqUSU3eqcaWwvVj0ZgAm32xuZ+75q FN5nbD/fD4u7lXMZT/IPcpqhYpAKnk1QvUlgF2LctoybYoMnaJ7TSoy+NYL/JPHSX/q4it KGA95Y1SnAGnuq1pF+GFpTcGvmdd7cs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774522154; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=k6WIL/CPxi5yzw8jRwBaVYznmdI4kDLcX63WUAhouhQ=; b=CJ2rvj9oxDxuwbi8Wrk9bGDvwgKoAXTKamKO1AfyzoqUSU3eqcaWwvVj0ZgAm32xuZ+75q FN5nbD/fD4u7lXMZT/IPcpqhYpAKnk1QvUlgF2LctoybYoMnaJ7TSoy+NYL/JPHSX/q4it KGA95Y1SnAGnuq1pF+GFpTcGvmdd7cs= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-204-49IjD0dQNSmL208bogD7jQ-1; Thu, 26 Mar 2026 06:49:12 -0400 X-MC-Unique: 49IjD0dQNSmL208bogD7jQ-1 X-Mimecast-MFC-AGG-ID: 49IjD0dQNSmL208bogD7jQ_1774522150 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id DC199195608B; Thu, 26 Mar 2026 10:49:09 +0000 (UTC) Received: from warthog.procyon.org.com (unknown [10.44.33.121]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 1B5B619560B1; Thu, 26 Mar 2026 10:49:02 +0000 (UTC) From: David Howells To: Christian Brauner , Matthew Wilcox , Christoph Hellwig Cc: David Howells , Paulo Alcantara , Jens Axboe , Leon Romanovsky , Steve French , ChenXiaoSong , Marc Dionne , Eric Van Hensbergen , Dominique Martinet , Ilya Dryomov , Trond Myklebust , netfs@lists.linux.dev, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Paulo Alcantara Subject: [PATCH 21/26] netfs: Remove netfs_extract_user_iter() Date: Thu, 26 Mar 2026 10:45:36 +0000 Message-ID: <20260326104544.509518-22-dhowells@redhat.com> In-Reply-To: <20260326104544.509518-1-dhowells@redhat.com> References: <20260326104544.509518-1-dhowells@redhat.com> X-Mailing-List: linux-erofs@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-MFC-PROC-ID: jHpqlHN_Bljq_SzaPOIrsuMowjfdtALjn-_7XEWPut0_1774522150 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true Remove netfs_extract_user_iter() as it has been replaced with netfs_extract_iter(). Signed-off-by: David Howells cc: Paulo Alcantara cc: Matthew Wilcox cc: Christoph Hellwig cc: Steve French cc: linux-cifs@vger.kernel.org cc: netfs@lists.linux.dev cc: linux-fsdevel@vger.kernel.org --- fs/netfs/iterator.c | 96 ------------------------------------------- include/linux/netfs.h | 3 -- 2 files changed, 99 deletions(-) diff --git a/fs/netfs/iterator.c b/fs/netfs/iterator.c index 581dbf650a19..442f893a0d65 100644 --- a/fs/netfs/iterator.c +++ b/fs/netfs/iterator.c @@ -137,102 +137,6 @@ ssize_t netfs_extract_iter(struct iov_iter *orig, size_t orig_len, size_t max_se EXPORT_SYMBOL_GPL(netfs_extract_iter); #if 0 -/** - * netfs_extract_user_iter - Extract the pages from a user iterator into a bvec - * @orig: The original iterator - * @orig_len: The amount of iterator to copy - * @new: The iterator to be set up - * @extraction_flags: Flags to qualify the request - * - * Extract the page fragments from the given amount of the source iterator and - * build up a second iterator that refers to all of those bits. This allows - * the original iterator to be disposed of. - * - * @extraction_flags can have ITER_ALLOW_P2PDMA set to request peer-to-peer DMA be - * allowed on the pages extracted. - * - * On success, the number of elements in the bvec is returned, the original - * iterator will have been advanced by the amount extracted. - * - * The iov_iter_extract_mode() function should be used to query how cleanup - * should be performed. - */ -ssize_t netfs_extract_user_iter(struct iov_iter *orig, size_t orig_len, - struct iov_iter *new, - iov_iter_extraction_t extraction_flags) -{ - struct bio_vec *bv = NULL; - struct page **pages; - unsigned int cur_npages; - unsigned int max_pages; - unsigned int npages = 0; - unsigned int i; - ssize_t ret; - size_t count = orig_len, offset, len; - size_t bv_size, pg_size; - - if (WARN_ON_ONCE(!iter_is_ubuf(orig) && !iter_is_iovec(orig))) - return -EIO; - - max_pages = iov_iter_npages(orig, INT_MAX); - bv_size = array_size(max_pages, sizeof(*bv)); - bv = kvmalloc(bv_size, GFP_KERNEL); - if (!bv) - return -ENOMEM; - - /* Put the page list at the end of the bvec list storage. bvec - * elements are larger than page pointers, so as long as we work - * 0->last, we should be fine. - */ - pg_size = array_size(max_pages, sizeof(*pages)); - pages = (void *)bv + bv_size - pg_size; - - while (count && npages < max_pages) { - ret = iov_iter_extract_pages(orig, &pages, count, - max_pages - npages, extraction_flags, - &offset); - if (unlikely(ret <= 0)) { - ret = ret ?: -EIO; - break; - } - - if (ret > count) { - pr_err("get_pages rc=%zd more than %zu\n", ret, count); - break; - } - - count -= ret; - ret += offset; - cur_npages = DIV_ROUND_UP(ret, PAGE_SIZE); - - if (npages + cur_npages > max_pages) { - pr_err("Out of bvec array capacity (%u vs %u)\n", - npages + cur_npages, max_pages); - break; - } - - for (i = 0; i < cur_npages; i++) { - len = ret > PAGE_SIZE ? PAGE_SIZE : ret; - bvec_set_page(bv + npages + i, *pages++, len - offset, offset); - ret -= len; - offset = 0; - } - - npages += cur_npages; - } - - if (ret < 0 && (ret == -ENOMEM || npages == 0)) { - for (i = 0; i < npages; i++) - unpin_user_page(bv[i].bv_page); - kvfree(bv); - return ret; - } - - iov_iter_bvec(new, orig->data_source, bv, npages, orig_len - count); - return npages; -} -EXPORT_SYMBOL_GPL(netfs_extract_user_iter); - /* * Select the span of a bvec iterator we're going to use. Limit it by both maximum * size and maximum number of segments. Returns the size of the span in bytes. diff --git a/include/linux/netfs.h b/include/linux/netfs.h index 9d8576a62868..65e39f9b0c10 100644 --- a/include/linux/netfs.h +++ b/include/linux/netfs.h @@ -448,9 +448,6 @@ void netfs_put_subrequest(struct netfs_io_subrequest *subreq, ssize_t netfs_extract_iter(struct iov_iter *orig, size_t orig_len, size_t max_segs, unsigned long long fpos, struct bvecq **_bvecq_head, iov_iter_extraction_t extraction_flags); -ssize_t netfs_extract_user_iter(struct iov_iter *orig, size_t orig_len, - struct iov_iter *new, - iov_iter_extraction_t extraction_flags); size_t netfs_limit_iter(const struct iov_iter *iter, size_t start_offset, size_t max_size, size_t max_segs); void netfs_prepare_write_failed(struct netfs_io_subrequest *subreq);