From: Nithurshen <nithurshen.dev@gmail.com>
To: nithurshen.dev@gmail.com
Cc: hsiangkao@linux.alibaba.com, linux-erofs@lists.ozlabs.org,
xiang@kernel.org, stopire@gmail.com
Subject: [PATCH v2] erofs-utils: s3: fix memory leak in s3erofs_create_object_iterator
Date: Sun, 5 Apr 2026 12:02:08 +0530 [thread overview]
Message-ID: <20260405063208.4617-1-nithurshen.dev@gmail.com> (raw)
In-Reply-To: <20260404082737.87032-1-nithurshen.dev@gmail.com>
In s3erofs_create_object_iterator(), if the parsed prefix length
exceeds S3EROFS_PATH_MAX, the function aborts and returns an
-EINVAL error pointer. However, the 'iter' structure was already
allocated via calloc() and left unfreed, causing a memory leak.
This commit adds the missing free(iter) call in the error path to
prevent leaking memory when excessively long S3 bucket paths are
provided.
Signed-off-by: Nithurshen <nithurshen.dev@gmail.com>
---
lib/remotes/s3.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/remotes/s3.c b/lib/remotes/s3.c
index 768232a..abfa5dc 100644
--- a/lib/remotes/s3.c
+++ b/lib/remotes/s3.c
@@ -911,8 +911,10 @@ s3erofs_create_object_iterator(struct erofs_s3 *s3, const char *path,
iter->bucket = NULL;
iter->prefix = strdup(path + 1);
} else {
- if (++prefix - path > S3EROFS_PATH_MAX)
+ if (++prefix - path > S3EROFS_PATH_MAX) {
+ free(iter);
return ERR_PTR(-EINVAL);
+ }
iter->bucket = strndup(path, prefix - path);
iter->prefix = strdup(prefix);
}
--
2.52.0
prev parent reply other threads:[~2026-04-05 6:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-04 8:27 [PATCH] erofs-utils: s3: fix memory leak in s3erofs_create_object_iterator Nithurshen
2026-04-05 6:22 ` Yifan Zhao
2026-04-05 6:32 ` Nithurshen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260405063208.4617-1-nithurshen.dev@gmail.com \
--to=nithurshen.dev@gmail.com \
--cc=hsiangkao@linux.alibaba.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=stopire@gmail.com \
--cc=xiang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox