public inbox for linux-erofs@ozlabs.org
 help / color / mirror / Atom feed
From: Vansh Choudhary <ch@vnsh.in>
To: Gao Xiang <hsiangkao@linux.alibaba.com>
Cc: Vansh Choudhary <ch@vnsh.in>, linux-erofs@lists.ozlabs.org
Subject: Re: [PATCH] erofs-utils: tar: fix negative GNU base-256 number parsing
Date: Wed,  8 Apr 2026 04:41:23 +0000	[thread overview]
Message-ID: <20260408044123.2553-1-ch@vnsh.in> (raw)
In-Reply-To: <ecdd65aa-0dc1-41fc-afb1-d949ca8f5fa9@linux.alibaba.com>

Yes, this definitely fixes the signed-overflow UB in tarerofs_parsenum(),
and also makes the negative GNU base-256 decoding logic correct.  But
from the current testcase alone, I cannot firmly show a visible end-user
failure on the old code path.

So I think this is safest to describe as a correctness + UB fix.

Thanks,
Vansh


      reply	other threads:[~2026-04-08  4:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-05 10:18 [PATCH] erofs-utils: tar: fix negative GNU base-256 number parsing Vansh Choudhary
2026-04-07  9:35 ` Gao Xiang
2026-04-07 18:13   ` [PATCH] erofs-utils: tests: add test for negative GNU tar mtimes Vansh Choudhary
2026-04-08  3:33     ` [PATCH v2] " Gao Xiang
2026-04-08  3:36 ` [PATCH] erofs-utils: tar: fix negative GNU base-256 number parsing Gao Xiang
2026-04-08  4:41   ` Vansh Choudhary [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260408044123.2553-1-ch@vnsh.in \
    --to=ch@vnsh.in \
    --cc=hsiangkao@linux.alibaba.com \
    --cc=linux-erofs@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox