From: Lucas Karpinski <lkarpinski@nvidia.com>
To: linux-erofs@lists.ozlabs.org
Cc: jcalmels@nvidia.com, Lucas Karpinski <lkarpinski@nvidia.com>
Subject: [PATCH v3 1/4] erofs-utils: lib: remove redundant if check
Date: Tue, 14 Apr 2026 15:10:39 -0400 [thread overview]
Message-ID: <20260414-merge-fs-v3-1-266bd1367fd2@nvidia.com> (raw)
In-Reply-To: <20260414-merge-fs-v3-0-266bd1367fd2@nvidia.com>
Remove the if check since erofs_set_inode_fingerprint is already protected
by the same if statement.
Signed-off-by: Lucas Karpinski <lkarpinski@nvidia.com>
---
lib/inode.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/lib/inode.c b/lib/inode.c
index c932981a..2f78d9b8 100644
--- a/lib/inode.c
+++ b/lib/inode.c
@@ -2018,11 +2018,9 @@ static int erofs_mkfs_begin_nondirectory(const struct erofs_mkfs_btctx *btctx,
goto out;
}
- if (S_ISREG(inode->i_mode) && inode->i_size) {
- ret = erofs_set_inode_fingerprint(inode, ctx.fd, ctx.fpos);
- if (ret < 0)
- return ret;
- }
+ ret = erofs_set_inode_fingerprint(inode, ctx.fd, ctx.fpos);
+ if (ret < 0)
+ return ret;
if (inode->sbi->available_compr_algs &&
erofs_file_is_compressible(im, inode)) {
--
Git-155)
next prev parent reply other threads:[~2026-04-14 19:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-14 19:10 [PATCH v3 0/4] erofs-utils: implement the FULLDATA rebuild mode Lucas Karpinski
2026-04-14 19:10 ` Lucas Karpinski [this message]
2026-04-14 19:10 ` [PATCH v3 2/4] erofs-utils: lib: add helper function erofs_uuid_unparse_as_tag Lucas Karpinski
2026-04-14 19:10 ` [PATCH v3 3/4] erofs-utils: mfks: add rebuild FULLDATA for combined EROFS images Lucas Karpinski
2026-04-15 3:35 ` zhaoyifan (H)
2026-04-15 7:47 ` Gao Xiang
2026-04-15 13:30 ` Lucas Karpinski
2026-04-14 19:10 ` [PATCH v3 4/4] erofs-utils: manpages: update to reflect fulldata support Lucas Karpinski
2026-04-15 2:07 ` [PATCH v3 0/4] erofs-utils: implement the FULLDATA rebuild mode Gao Xiang
2026-04-15 14:09 ` Lucas Karpinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260414-merge-fs-v3-1-266bd1367fd2@nvidia.com \
--to=lkarpinski@nvidia.com \
--cc=jcalmels@nvidia.com \
--cc=linux-erofs@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox