Re: [PATCH] erofs-utils: lib: check NULL from erofs_rebuild_get_dentry()

Gao Xiang
2026-04-21T02:16:43Z

On 2026/4/21 01:47, Vansh Choudhary wrote:
> erofs_rebuild_get_dentry() returns NULL when the input path
> normalizes to nothing (".", "/", "//", or paths that collapse via
> ".."). The tar hardlink branch and the S3 import loop only check
> IS_ERR() and then dereference the result.
>
> Reject a hardlink target that resolves to root with -EISDIR, and
> treat a root-normalized S3 key as the root inode itself.
>
> Fixes: 95d315fd7958 ("erofs-utils: introduce tarerofs")
> Fixes: 29728ba8f6f6 ("erofs-utils: mkfs: support EROFS meta-only image generation from S3")
> Signed-off-by: Vansh Choudhary <ch@vnsh.in>

Need a reproducer to experimental-tests before advancing this.

Thanks,
Gao Xiang