From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 796DDCD8C9D for ; Mon, 8 Jun 2026 14:59:01 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4gYw935dBtz3btn; Tue, 09 Jun 2026 00:56:23 +1000 (AEST) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1780930583; cv=none; b=KZzQy4TcnD7FJGOuQkLOUCyMOiQlu61rDyO5aWUgvQl7MXW0101ByD530pAQQIFJ87YWqSIQAxlW25zw0IFFiQYdxvD9ir25xO0TYzZ2nHF+Bo6MufwhtDrk+t/LSvEPdiXM8VJ+q1enFUE77LTHQjo+5LRf1frrVeFakN8bD0KTGMo6z4RJdTKIcQxJYiV5KCc/Yzuv1CFxwu0dEgai/yuKStiWQBtnmQBoFccaSeeSArukCdhK0aWW9wnp+J06UQ28Q9EirgDH+Xzvwk5Wrvc6HhyP3TV/fCwnc5X7+Ztq8nyRhwAswfl7qAOWZMcsYmDfK+gGLBfvcLvuOY88BA== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1780930583; c=relaxed/relaxed; bh=vbkc2ThYu5P21iahS6kl0ozQ9hmor5lbvUCQK6sK6n0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:content-type; b=gxMEMvQrjRgANJExpD5/v19PJtonw0foHe51XlB3Kh+Tuq6ZZoWRGccO1EUV06Qzf3Wkn5l2UCa/JBfGN5itbX1sqp1uviN3nzzvv9zRQnQHYdU5EXRZiT7gpXwr1rFfmV7rZAigXGgvrL+fDvgMRjd3I2Vhbp4kq3s+5YFvGnjhlrSNlaWH2wEi8tjYCp6kUD28Ea0YKl+V2NTeml/EgQVEJfscCLqg+w52hxKB8HAfBuX4qLLYTDLziuFv4qgqOCGOMpd0t/5kk8QMs+ozEqi87gNnBPMfFGCFyTmytF+iwi5v+eKE/NyIBBA65Ii3v6qYVArHi1HeZ2sU+RuRKg== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=RfqXaK5w; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=X5L4d/t5; dkim-atps=neutral; spf=pass (client-ip=170.10.129.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=dhowells@redhat.com; receiver=lists.ozlabs.org) smtp.mailfrom=redhat.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=RfqXaK5w; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=X5L4d/t5; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=redhat.com (client-ip=170.10.129.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=dhowells@redhat.com; receiver=lists.ozlabs.org) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4gYw92628rz30FP for ; Tue, 09 Jun 2026 00:56:22 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780930579; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vbkc2ThYu5P21iahS6kl0ozQ9hmor5lbvUCQK6sK6n0=; b=RfqXaK5wSLjPHRqxBneFN7YBK1ldJdVhuRp2Vs1br11FPhgCvFDksunQ58Z29zdwu+aw/X 4806XYCjCbn7yNDOsB7A+rScnwyHYJ8NG1WNaCcbFJhwOJ0gGAQUs2UGOuTz6Pr+MzfC+x p9Q7rsE8p+Gs+nVLD5cNoa3kVY7iVJw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780930580; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vbkc2ThYu5P21iahS6kl0ozQ9hmor5lbvUCQK6sK6n0=; b=X5L4d/t53aVlkXzRj8GdHkVTO0BnJ64df4evKu+iYAxevcQWswAas8hV5Gt2hknqhLaAPo N3T1bNsP4CYoq7QwlSgBwzNqA5tEXzf5g6xQxHy/KaiNMnWogCRp/wo0wjQWnTUA9qIQ0G 2KMdHbWMDA8NLCf66DQ0ci9EBCaTASY= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-449-JtDZMFVCO924HqhQ9bPR9w-1; Mon, 08 Jun 2026 10:56:14 -0400 X-MC-Unique: JtDZMFVCO924HqhQ9bPR9w-1 X-Mimecast-MFC-AGG-ID: JtDZMFVCO924HqhQ9bPR9w_1780930571 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 67CD0195607A; Mon, 8 Jun 2026 14:56:11 +0000 (UTC) Received: from warthog.procyon.org.com (unknown [10.44.32.43]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 4F8493008B35; Mon, 8 Jun 2026 14:56:05 +0000 (UTC) From: David Howells To: Christian Brauner , Matthew Wilcox , Christoph Hellwig Cc: David Howells , Paulo Alcantara , Jens Axboe , Leon Romanovsky , Steve French , ChenXiaoSong , Marc Dionne , Eric Van Hensbergen , Dominique Martinet , Ilya Dryomov , Trond Myklebust , netfs@lists.linux.dev, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 10/22] netfs: Add a function to extract from an iter into a bvecq Date: Mon, 8 Jun 2026 15:54:18 +0100 Message-ID: <20260608145432.681865-11-dhowells@redhat.com> In-Reply-To: <20260608145432.681865-1-dhowells@redhat.com> References: <20260608145432.681865-1-dhowells@redhat.com> X-Mailing-List: linux-erofs@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-MFC-PROC-ID: Wt4ovri8Mx_Vkqh3LHybLtkMpcTEoxMAJ1939I86LNM_1780930571 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true Add a function to extract a slice of data from an iterator of any type into a bvec queue chain. Signed-off-by: David Howells cc: Paulo Alcantara cc: Matthew Wilcox cc: Christoph Hellwig cc: Steve French cc: linux-cifs@vger.kernel.org cc: netfs@lists.linux.dev cc: linux-fsdevel@vger.kernel.org --- fs/netfs/iterator.c | 125 ++++++++++++++++++++++++++++++++++++++++++ include/linux/netfs.h | 3 + 2 files changed, 128 insertions(+) diff --git a/fs/netfs/iterator.c b/fs/netfs/iterator.c index b375567e0520..d2c3055a488c 100644 --- a/fs/netfs/iterator.c +++ b/fs/netfs/iterator.c @@ -13,6 +13,131 @@ #include #include "internal.h" +/** + * netfs_extract_iter - Extract virtually contiguous pages from an iterator into a bvecq + * @orig: The original iterator + * @max_len: Maximum number of bytes to extract + * @max_pages: Maximum number of pages to extract + * @fpos: Starting file position to label the bvecq with + * @_bvecq_head: Where to cache the bvec queue + * @extraction_flags: Flags to qualify the request + * + * Extract virtually contiguous page fragments from the source iterator up to + * the given maxima and build bvec queue that refers to all of those bits. + * This allows the original iterator to disposed of. + * + * @extraction_flags can have ITER_ALLOW_P2PDMA set to request peer-to-peer DMA be + * allowed on the pages extracted. + * + * On success, the amount of data in the bvec is returned, the original + * iterator will have been advanced by the amount extracted. + * + * The bvecq segments are marked with indications on how to get clean up the + * extracted fragments. + */ +ssize_t netfs_extract_iter(struct iov_iter *orig, size_t max_len, size_t max_pages, + unsigned long long fpos, struct bvecq **_bvecq_head, + iov_iter_extraction_t extraction_flags) +{ + struct bvecq *bq_tail = NULL; + ssize_t ret = 0; + size_t extracted = 0; + + _enter("{%u,%zx},%zx", orig->iter_type, orig->count, max_len); + + if (max_len > orig->count) + max_len = orig->count; + if (WARN_ON_ONCE(!max_len || !max_pages)) + return 0; + + max_pages = iov_iter_npages(orig, max_pages); + if (!max_pages) + return 0; + + do { + struct bvecq *bq; + + bq = bvecq_alloc_one(max_pages, GFP_NOFS); + if (!bq) { + ret = -ENOMEM; + break; + } + if (user_backed_iter(orig)) + bq->mem_type = iov_iter_extract_will_pin(orig) ? + BVECQ_MEM_GUP : BVECQ_MEM_PAGECACHE; + bq->prev = bq_tail; + bq->fpos = fpos + extracted; + + if (bq_tail) + bq_tail->next = bq; + else + *_bvecq_head = bq; + bq_tail = bq; + + if (max_len == 0) + break; + + struct bio_vec *bv = bq->bv; + do { + struct page **pages; + ssize_t got; + size_t offset; + size_t space = bq->max_slots - bq->nr_slots; + size_t bv_size = array_size(bq->max_slots, sizeof(*bv)); + size_t pg_size = array_size(space, sizeof(*pages)); + + /* Put the page list at the end of the bvec list + * storage. bvec elements are larger than page + * pointers, so as long as we work 0->last, we should + * be fine. + */ + pages = (void *)bv + bv_size - pg_size; + + got = iov_iter_extract_pages(orig, &pages, max_len, + space, extraction_flags, &offset); + if (got < 0) { + ret = got; + goto out; + } + + if (got == 0) { + pr_err("extract_pages gave nothing from %zu, %zu\n", + extracted, max_len); + ret = -EIO; + goto out; + } + + if (WARN(got > max_len, + "%s: extract_pages overrun %zd > %zu bytes\n", + __func__, got, max_len)) { + ret = -EIO; + break; + } + + extracted += got; + max_len -= got; + + do { + size_t len = umin(got, PAGE_SIZE - offset); + + BUG_ON(bq->nr_slots >= bq->max_slots); + + bvec_set_page(&bq->bv[bq->nr_slots], + *pages++, len, offset); + bq->nr_slots++; + got -= len; + offset = 0; + } while (got > 0); + } while (max_len > 0 && !bvecq_is_full(bq)); + + max_pages -= bq->nr_slots; + } while (max_len > 0 && max_pages > 0); + +out: + return extracted ?: ret; +} +EXPORT_SYMBOL_GPL(netfs_extract_iter); + /** * netfs_extract_user_iter - Extract the pages from a user iterator into a bvec * @orig: The original iterator diff --git a/include/linux/netfs.h b/include/linux/netfs.h index 12e5c51c11c8..40f45ecf1db8 100644 --- a/include/linux/netfs.h +++ b/include/linux/netfs.h @@ -460,6 +460,9 @@ void netfs_get_subrequest(struct netfs_io_subrequest *subreq, enum netfs_sreq_ref_trace what); void netfs_put_subrequest(struct netfs_io_subrequest *subreq, enum netfs_sreq_ref_trace what); +ssize_t netfs_extract_iter(struct iov_iter *orig, size_t max_len, size_t max_pages, + unsigned long long fpos, struct bvecq **_bvecq_head, + iov_iter_extraction_t extraction_flags); ssize_t netfs_extract_user_iter(struct iov_iter *orig, size_t orig_len, struct iov_iter *new, iov_iter_extraction_t extraction_flags);