From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 45E7FC55172 for ; Tue, 4 Aug 2026 10:04:18 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4hDpzh44NWz2ygL; Tue, 04 Aug 2026 20:04:16 +1000 (AEST) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1785837856; cv=none; b=cGh+eSxMJlq/habjnK8mKvsyRhnuMqWRT2VFc3yvYtJQLgm0PQhwwpczSkK9pljy+iVXTtfh+8KAIeFF8jpQngvA2oB5MVAsxLurvtHFJiIumsMsYjpzVpQlHxELyYg/jOrTaYN91enKEZsBG0D1hKawTJz214CbG2h4ZnFnMdC3ta7fk9SgGFkUxoddg3fK8BAJSeeKlPdMLzxNf4N7/pdnBJPFcaQTW09IZZIuoVFhKS1TMsFwlLiHLTc3TgWogCZKcpxQUvkdWz3zwNgYICB+OD/RDYH38mRxuOyHvuF/R75F01rWDDBhxhtXvX8OQkBNqEFF06wxlgdoInXLwg== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1785837856; c=relaxed/relaxed; bh=lZ3ILMb6nbwwWl23lzGWnrijHqvu/92rCNMhXviJEOc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:content-type; b=mWJMWlfgre3mDSx55NT0q8Ds07dKEdHIvzN6L4rcz5YO79V03InCJUDyMOchvLGOZ1xE2GWPShUDwPsXGwH+WybDALisUPKPUWHcxcwP1A1IWw2qUob0fLyuwJjH+Xz7jfVv3UY637hiv2pd/XmR7Za7oVdWG1Bc1iJz3kel7HkjFDeQNS/UUiq0ipYovF9zSJvQR7tNWO9Hp0BJZFUcwkzX+Q5+6uJpwTHlq7mkaq49RskOpAyAaRrxHnJptywFkveGNte+Ralk8H1bP1cTlyR/dvXJxJlKCRSkAUiwf5MkVybhZmwCKJXyjoHpk9lbqlFZEVup/689MVG1pp/oQA== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=TdnWHjFu; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Vd2C8oN2; dkim-atps=neutral; spf=pass (client-ip=170.10.129.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=dhowells@redhat.com; receiver=lists.ozlabs.org) smtp.mailfrom=redhat.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=TdnWHjFu; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Vd2C8oN2; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=redhat.com (client-ip=170.10.129.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=dhowells@redhat.com; receiver=lists.ozlabs.org) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4hDpzg4gKYz2xpn for ; Tue, 04 Aug 2026 20:04:15 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1785837852; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lZ3ILMb6nbwwWl23lzGWnrijHqvu/92rCNMhXviJEOc=; b=TdnWHjFuiTln0+oDGzRC1S4b8M0YZsaa17n2dBC8oFjVCCzhn4QjFLR1/npNVxR9WHJNcd g5SfpRWtp9EEnL+fPOWzbORsafWusubVM7TpRQCenWk5YAeFaZb0B1qEjYzsnbZRM1mbKl a7Gh6yFxF7mmoN/Q5khDZpxY2SJ0uxk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1785837853; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lZ3ILMb6nbwwWl23lzGWnrijHqvu/92rCNMhXviJEOc=; b=Vd2C8oN2FfUwjdi3W4ZnxQlCDEbUAcRivlWzvtEjT7BefDTXnmjaWkCQT6TUOqe7BT1tqq xG6cKCv0cTqd93WMf0Gfy9l5mKjaBbTjVXH1aQMYfogLnQK1+iKpDFcKSQdCIwu6+TqsEM /P+6LEMJJTfH+qC/tlmN7N5AerS3Oqc= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-443-IcJzwte4PK6SuIS9sFRvRw-1; Tue, 04 Aug 2026 06:04:06 -0400 X-MC-Unique: IcJzwte4PK6SuIS9sFRvRw-1 X-Mimecast-MFC-AGG-ID: IcJzwte4PK6SuIS9sFRvRw_1785837843 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A6B7D19560A7; Tue, 4 Aug 2026 10:04:02 +0000 (UTC) Received: from warthog.procyon.org.com (unknown [10.44.32.44]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 85C5D429; Tue, 4 Aug 2026 10:03:56 +0000 (UTC) From: David Howells To: Christian Brauner , Matthew Wilcox , Christoph Hellwig Cc: David Howells , Paulo Alcantara , Jens Axboe , Leon Romanovsky , Steve French , ChenXiaoSong , Marc Dionne , Stefan Metzmacher , Eric Van Hensbergen , Dominique Martinet , Ilya Dryomov , netfs@lists.linux.dev, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v8 10/25] cifs: Use a bvecq for buffering instead of a folioq Date: Tue, 4 Aug 2026 11:02:05 +0100 Message-ID: <20260804100224.2748935-11-dhowells@redhat.com> In-Reply-To: <20260804100224.2748935-1-dhowells@redhat.com> References: <20260804100224.2748935-1-dhowells@redhat.com> X-Mailing-List: linux-erofs@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 X-Mimecast-MFC-PROC-ID: JbjGtBI7jDdajwPz9CupHcOgk-Wk_M7W5Cw2ehz4MWA_1785837843 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true Use a bvecq for internal buffering for crypto purposes instead of a folioq so that the latter can be phased out. Signed-off-by: David Howells cc: Paulo Alcantara cc: Matthew Wilcox cc: Christoph Hellwig cc: Steve French cc: linux-cifs@vger.kernel.org cc: netfs@lists.linux.dev cc: linux-fsdevel@vger.kernel.org --- fs/smb/client/cifsglob.h | 2 +- fs/smb/client/smb2ops.c | 76 +++++++++++++++++++--------------------- 2 files changed, 37 insertions(+), 41 deletions(-) diff --git a/fs/smb/client/cifsglob.h b/fs/smb/client/cifsglob.h index 79e4e84f8985..c8b1c23ef494 100644 --- a/fs/smb/client/cifsglob.h +++ b/fs/smb/client/cifsglob.h @@ -289,7 +289,7 @@ struct smb_rqst { struct kvec *rq_iov; /* array of kvecs */ unsigned int rq_nvec; /* number of kvecs in array */ struct iov_iter rq_iter; /* Data iterator */ - struct folio_queue *rq_buffer; /* Buffer for encryption */ + struct bvecq *rq_buffer; /* Buffer for encryption */ }; struct mid_q_entry; diff --git a/fs/smb/client/smb2ops.c b/fs/smb/client/smb2ops.c index 192649fec25d..2b5d745ba16e 100644 --- a/fs/smb/client/smb2ops.c +++ b/fs/smb/client/smb2ops.c @@ -4683,19 +4683,18 @@ crypt_message(struct TCP_Server_Info *server, int num_rqst, } /* - * Copy data from an iterator to the folios in a folio queue buffer. + * Copy data from an iterator to the pages in a bvec queue buffer. */ -static bool cifs_copy_iter_to_folioq(struct iov_iter *iter, size_t size, - struct folio_queue *buffer) +static bool cifs_copy_iter_to_bvecq(struct iov_iter *iter, size_t size, + struct bvecq *buffer) { for (; buffer; buffer = buffer->next) { - for (int s = 0; s < folioq_count(buffer); s++) { - struct folio *folio = folioq_folio(buffer, s); - size_t part = folioq_folio_size(buffer, s); + for (int s = 0; s < buffer->nr_slots; s++) { + struct bio_vec *bv = &buffer->bv[s]; + size_t part = umin(bv->bv_len, size); - part = umin(part, size); - - if (copy_folio_from_iter(folio, 0, part, iter) != part) + if (copy_page_from_iter(bv->bv_page, bv->bv_offset, + part, iter) != part) return false; size -= part; } @@ -4707,7 +4706,7 @@ void smb3_free_compound_rqst(int num_rqst, struct smb_rqst *rqst) { for (int i = 0; i < num_rqst; i++) - netfs_free_folioq_buffer(rqst[i].rq_buffer); + bvecq_put(rqst[i].rq_buffer); } /* @@ -4734,7 +4733,7 @@ smb3_init_transform_rq(struct TCP_Server_Info *server, int num_rqst, for (int i = 1; i < num_rqst; i++) { struct smb_rqst *old = &old_rq[i - 1]; struct smb_rqst *new = &new_rq[i]; - struct folio_queue *buffer = NULL; + struct bvecq *buffer = NULL; size_t size = iov_iter_count(&old->rq_iter); orig_len += smb_rqst_len(server, old); @@ -4742,17 +4741,16 @@ smb3_init_transform_rq(struct TCP_Server_Info *server, int num_rqst, new->rq_nvec = old->rq_nvec; if (size > 0) { - size_t cur_size = 0; - rc = netfs_alloc_folioq_buffer(NULL, &buffer, &cur_size, - size, GFP_NOFS); - new->rq_buffer = buffer; - if (rc < 0) + rc = -ENOMEM; + buffer = bvecq_alloc_buffer(size, GFP_NOFS); + if (!buffer) goto err_free; - iov_iter_folio_queue(&new->rq_iter, ITER_SOURCE, - buffer, 0, 0, size); + new->rq_buffer = buffer; + iov_iter_bvec_queue(&new->rq_iter, ITER_SOURCE, + buffer, 0, 0, size); - if (!cifs_copy_iter_to_folioq(&old->rq_iter, size, buffer)) { + if (!cifs_copy_iter_to_bvecq(&old->rq_iter, size, buffer)) { rc = smb_EIO1(smb_eio_trace_tx_copy_iter_to_buf, size); goto err_free; } @@ -4842,22 +4840,20 @@ decrypt_raw_data(struct TCP_Server_Info *server, char *buf, } static int -cifs_copy_folioq_to_iter(struct folio_queue *folioq, size_t data_size, - size_t skip, struct iov_iter *iter) +cifs_copy_bvecq_to_iter(struct bvecq *bq, size_t data_size, + size_t skip, struct iov_iter *iter) { - for (; folioq; folioq = folioq->next) { - for (int s = 0; s < folioq_count(folioq); s++) { - struct folio *folio; - size_t fsize, n, len; + for (; bq; bq = bq->next) { + for (int s = 0; s < bq->nr_slots; s++) { + struct bio_vec *bv = &bq->bv[s]; + size_t n, len; if (data_size == 0) return 0; - folio = folioq_folio(folioq, s); - fsize = folio_size(folio); - len = umin(fsize - skip, data_size); + len = umin(bv->bv_len - skip, data_size); - n = copy_folio_to_iter(folio, skip, len, iter); + n = copy_page_to_iter(bv->bv_page, bv->bv_offset + skip, len, iter); if (n != len) { cifs_dbg(VFS, "%s: something went wrong\n", __func__); return smb_EIO2(smb_eio_trace_rx_copy_to_iter, @@ -4879,7 +4875,7 @@ cifs_copy_folioq_to_iter(struct folio_queue *folioq, size_t data_size, static int handle_read_data(struct TCP_Server_Info *server, struct mid_q_entry *mid, - char *buf, unsigned int buf_len, struct folio_queue *buffer, + char *buf, unsigned int buf_len, struct bvecq *buffer, unsigned int buffer_len, bool is_offloaded) { unsigned int data_offset; @@ -4989,8 +4985,8 @@ handle_read_data(struct TCP_Server_Info *server, struct mid_q_entry *mid, } /* Copy the data to the output I/O iterator. */ - rdata->result = cifs_copy_folioq_to_iter(buffer, data_len, - cur_off, &rdata->subreq.io_iter); + rdata->result = cifs_copy_bvecq_to_iter(buffer, data_len, + cur_off, &rdata->subreq.io_iter); if (rdata->result != 0) { if (is_offloaded) mid->mid_state = MID_RESPONSE_MALFORMED; @@ -5029,7 +5025,7 @@ handle_read_data(struct TCP_Server_Info *server, struct mid_q_entry *mid, struct smb2_decrypt_work { struct work_struct decrypt; struct TCP_Server_Info *server; - struct folio_queue *buffer; + struct bvecq *buffer; char *buf; unsigned int len; }; @@ -5043,7 +5039,7 @@ static void smb2_decrypt_offload(struct work_struct *work) struct mid_q_entry *mid; struct iov_iter iter; - iov_iter_folio_queue(&iter, ITER_DEST, dw->buffer, 0, 0, dw->len); + iov_iter_bvec_queue(&iter, ITER_DEST, dw->buffer, 0, 0, dw->len); rc = decrypt_raw_data(dw->server, dw->buf, dw->server->vals->read_rsp_size, &iter, true); if (rc) { @@ -5092,7 +5088,7 @@ static void smb2_decrypt_offload(struct work_struct *work) } free_pages: - netfs_free_folioq_buffer(dw->buffer); + bvecq_put(dw->buffer); cifs_small_buf_release(dw->buf); kfree(dw); } @@ -5138,12 +5134,12 @@ receive_encrypted_read(struct TCP_Server_Info *server, struct mid_q_entry **mid, dw->len = len; len = round_up(dw->len, PAGE_SIZE); - size_t cur_size = 0; - rc = netfs_alloc_folioq_buffer(NULL, &dw->buffer, &cur_size, len, GFP_NOFS); - if (rc < 0) + rc = -ENOMEM; + dw->buffer = bvecq_alloc_buffer(len, GFP_NOFS); + if (!dw->buffer) goto discard_data; - iov_iter_folio_queue(&iter, ITER_DEST, dw->buffer, 0, 0, len); + iov_iter_bvec_queue(&iter, ITER_DEST, dw->buffer, 0, 0, len); /* Read the data into the buffer and clear excess bufferage. */ rc = cifs_read_iter_from_socket(server, &iter, dw->len); @@ -5201,7 +5197,7 @@ receive_encrypted_read(struct TCP_Server_Info *server, struct mid_q_entry **mid, } free_pages: - netfs_free_folioq_buffer(dw->buffer); + bvecq_put(dw->buffer); free_dw: kfree(dw); return rc;