From: Gao Xiang <xiang@kernel.org>
To: linux-erofs@lists.ozlabs.org
Cc: "Gao Xiang" <xiang@kernel.org>, "Jan Čermák" <sairon@sairon.cz>
Subject: [PATCH] erofs-utils: mkfs: fix segfault with `--compress-hints`
Date: Wed, 7 Oct 2026 00:18:30 +0200 [thread overview]
Message-ID: <20261006221830.4763-1-xiang@kernel.org> (raw)
Reported-and-suggested-by: Jan Čermák <sairon@sairon.cz>
Fixes: bb9f75521465 ("erofs-utils: lib: migrate `c_compr_opts`")
Closes: https://github.com/erofs/erofs-utils/issues/56
Signed-off-by: Gao Xiang <xiang@kernel.org>
---
mkfs/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mkfs/main.c b/mkfs/main.c
index f0d3d8c..93123c1 100644
--- a/mkfs/main.c
+++ b/mkfs/main.c
@@ -1886,6 +1886,7 @@ int main(int argc, char **argv)
}
}
+ importer_params.z_paramsets = mkfscfg.zcfgs;
err = erofs_load_compress_hints(&importer, &g_sbi);
if (err) {
erofs_err("failed to load compress hints %s",
@@ -1895,7 +1896,6 @@ int main(int argc, char **argv)
if (mkfscfg.inlinexattr_tolerance < 0)
importer_params.no_xattrs = true;
- importer_params.z_paramsets = mkfscfg.zcfgs;
importer_params.source = cfg.c_src_path;
importer_params.no_datainline = mkfs_no_datainline;
importer_params.dot_omitted = mkfs_dot_omitted;
--
2.50.1 (Apple Git-155)
reply other threads:[~2026-10-06 22:18 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261006221830.4763-1-xiang@kernel.org \
--to=xiang@kernel.org \
--cc=linux-erofs@lists.ozlabs.org \
--cc=sairon@sairon.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox