From: Gao Xiang <hsiangkao@linux.alibaba.com>
To: Sri Lasya <lasyaprathipati@gmail.com>,
linux-erofs@lists.ozlabs.org, ChengyuZhu6 <hudson@cyzhu.com>
Cc: gaoxiang25@huawei.com
Subject: Re: [PATCH] erofs-utils: lib: fix potential NULL pointer dereference in docker_config.c
Date: Mon, 16 Mar 2026 12:35:02 +0800 [thread overview]
Message-ID: <2d26643a-6830-4667-81fe-2f03ea031f6d@linux.alibaba.com> (raw)
In-Reply-To: <20260315191422.1392-1-lasyaprathipati@gmail.com>
On 2026/3/16 03:14, Sri Lasya wrote:
> Signed-off-by: Sri Lasya <lasyaprathipati@gmail.com>
> ---
> lib/remotes/docker_config.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lib/remotes/docker_config.c b/lib/remotes/docker_config.c
> index 00db1bb..b346ee8 100644
> --- a/lib/remotes/docker_config.c
> +++ b/lib/remotes/docker_config.c
> @@ -38,7 +38,6 @@ static char *docker_config_path(void)
> {
> const char *dir;
> char *path = NULL;
> -
> dir = getenv("DOCKER_CONFIG");
> if (dir) {
> if (!*dir)
> @@ -203,6 +202,8 @@ int erofs_docker_config_lookup(const char *registry,
> }
>
> entry = json_object_iter_peek_value(&it);
> + if (!entry)
> + continue;
The patch format is broken, also Chengyu could you review it?
Thanks,
Gao Xiang
> if (json_object_object_get_ex(entry, "auth", &auth_field)) {
> b64 = json_object_get_string(auth_field);
> if (b64 && *b64) {
next prev parent reply other threads:[~2026-03-16 4:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-15 19:14 [PATCH] erofs-utils: lib: fix potential NULL pointer dereference in docker_config.c Sri Lasya
2026-03-16 4:35 ` Gao Xiang [this message]
2026-03-16 9:01 ` Sri Lasya Prathipati
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d26643a-6830-4667-81fe-2f03ea031f6d@linux.alibaba.com \
--to=hsiangkao@linux.alibaba.com \
--cc=gaoxiang25@huawei.com \
--cc=hudson@cyzhu.com \
--cc=lasyaprathipati@gmail.com \
--cc=linux-erofs@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox