From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57951C10F14 for ; Tue, 15 Oct 2019 15:53:29 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0542B2086A for ; Tue, 15 Oct 2019 15:53:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Tt1VTcLU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0542B2086A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 46t0MT64gvzDr40 for ; Wed, 16 Oct 2019 02:53:25 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::441; helo=mail-pf1-x441.google.com; envelope-from=blucerlee@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Tt1VTcLU"; dkim-atps=neutral Received: from mail-pf1-x441.google.com (mail-pf1-x441.google.com [IPv6:2607:f8b0:4864:20::441]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 46t0MJ2vmzzDqt3 for ; Wed, 16 Oct 2019 02:53:15 +1100 (AEDT) Received: by mail-pf1-x441.google.com with SMTP id y22so12757050pfr.3 for ; Tue, 15 Oct 2019 08:53:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=19a7QqLXO37VPcuNzrEa5Mxa0JH8jBlvNahxO5gAkcE=; b=Tt1VTcLUP5GbT0WnSd6+xc2qk4DOLXNjFjWbYnmZ/EpMa0fybVjTUufp9tkLmpXFvW yMGuFhNKqRMAFs3WogkIMUDtWwRRFa5+HWI4k25FCAtGG799bHpWXHSOjtbmfyWI1xBw ib6nI+ck2TmCe77XtFlHUdOa/HyKs33jOkEgcn2ecVzAYSYbOCHLhvTOh+7QCilSmkg3 fUbgkxDyuoZu8ymxP7TcdLaFlQxluB7v4WslGZLL8MNeDAUrIcUaKNVgo6UloAv80Mnn vsrSSpoXPRBUBtNw4eD4bhpiR0xmeEgbRR0+3jyLwa5pR7Z1e9K1xx4T6LSf2e0/lOpj LkSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=19a7QqLXO37VPcuNzrEa5Mxa0JH8jBlvNahxO5gAkcE=; b=tOako2+gpOZDnH6mPVkERGxSmIKZIWWE5fF3B/e1VoU+1sng8F3ghcYS4dRfXL2Pw9 CsWhrXqg+avgG13T31tePIV7DXcWfqtomXK0eQgWvWuiOFgYj8jp6ThCD2Cvr/kwX/5O 16T9Ln8gebOq13+SepO42JMtR57ydlmfW2LMeOHUnrNp9PWs7vMYvYq/WeRnX9xtXSnW C5q6WmDTQ88Gkm6strc2pjvePS4A8IY4NNcx5mDpQ1kA5XEyHMPzFHUD+IoApYlUZcuT 2j+UNyjZ6JluGMD1oDtwkKngKwsooWAq00mCKszsThPY2dvxo0H3KbcRSB4IPrWwFJuW eodQ== X-Gm-Message-State: APjAAAUPYKh70EXi/mgSUbZ5A7zsluHAazQsn0RY0kvRFYmvYHcjROyn vNsbu5BJNZyzPIt2uUZSBsw= X-Google-Smtp-Source: APXvYqxgL8gXFT7suvjMjSUGH11uFsPrxXcFZ+WSuD+oYtMDB8j77veZ6ivDzu1Gg0W2FNvWuYYoMQ== X-Received: by 2002:a62:5cc7:: with SMTP id q190mr40047337pfb.146.1571154794336; Tue, 15 Oct 2019 08:53:14 -0700 (PDT) Received: from [0.0.0.0] (li2016-34.members.linode.com. [172.105.123.34]) by smtp.gmail.com with ESMTPSA id x20sm24698752pfp.120.2019.10.15.08.53.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 15 Oct 2019 08:53:13 -0700 (PDT) Subject: Re: [PATCH v3] erofs-utils: use cmpsgn(x, y) for standardized large value comparsion To: Gao Xiang , Li Guifu , linux-erofs@lists.ozlabs.org References: <20191015155025.13215-1-hsiangkao@aol.com> From: Li Guifu Message-ID: <351025ef-dd71-5af9-48ec-8a2ea6b8e045@gmail.com> Date: Tue, 15 Oct 2019 23:53:02 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20191015155025.13215-1-hsiangkao@aol.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: linux-erofs@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development of Linux EROFS file system List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Miao Xie Errors-To: linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Sender: "Linux-erofs" > Previously, roundup(bb->buffers.off % EROFS_BLKSIZ, alignsize) > + incr + extrasize is an unsigned 64bit value and sgn(x) didn't > work properly. Fix it. > > Fixes: b0ca535297b6 ("erofs-utils: support 64-bit internal buffer cache") > Signed-off-by: Gao Xiang > --- It looks good Reviewed-by: Li Guifu Tested-by: Li Guifu Thanks,