From: Gao Xiang <hsiangkao@linux.alibaba.com>
To: Vansh Choudhary <ch@vnsh.in>, linux-erofs@lists.ozlabs.org
Subject: Re: [PATCH] erofs-utils: lib: check NULL from erofs_rebuild_get_dentry()
Date: Tue, 21 Apr 2026 10:16:33 +0800 [thread overview]
Message-ID: <3b50f2bd-44ba-46e6-95ac-0331c3cfbc4c@linux.alibaba.com> (raw)
In-Reply-To: <20260420174752.50132-1-ch@vnsh.in>
On 2026/4/21 01:47, Vansh Choudhary wrote:
> erofs_rebuild_get_dentry() returns NULL when the input path
> normalizes to nothing (".", "/", "//", or paths that collapse via
> ".."). The tar hardlink branch and the S3 import loop only check
> IS_ERR() and then dereference the result.
>
> Reject a hardlink target that resolves to root with -EISDIR, and
> treat a root-normalized S3 key as the root inode itself.
>
> Fixes: 95d315fd7958 ("erofs-utils: introduce tarerofs")
> Fixes: 29728ba8f6f6 ("erofs-utils: mkfs: support EROFS meta-only image generation from S3")
> Signed-off-by: Vansh Choudhary <ch@vnsh.in>
Need a reproducer to experimental-tests before advancing this.
Thanks,
Gao Xiang
next prev parent reply other threads:[~2026-04-21 2:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-20 17:47 [PATCH] erofs-utils: lib: check NULL from erofs_rebuild_get_dentry() Vansh Choudhary
2026-04-21 2:16 ` Gao Xiang [this message]
2026-04-21 17:23 ` [PATCH] erofs-utils: tests: add test for hardlink-to-root tar entries Vansh Choudhary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b50f2bd-44ba-46e6-95ac-0331c3cfbc4c@linux.alibaba.com \
--to=hsiangkao@linux.alibaba.com \
--cc=ch@vnsh.in \
--cc=linux-erofs@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox