From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CE1BAC6379F for ; Thu, 9 Feb 2023 02:30:55 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4PC17f2g2mz3chK for ; Thu, 9 Feb 2023 13:30:54 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.alibaba.com (client-ip=115.124.30.97; helo=out30-97.freemail.mail.aliyun.com; envelope-from=jefflexu@linux.alibaba.com; receiver=) Received: from out30-97.freemail.mail.aliyun.com (out30-97.freemail.mail.aliyun.com [115.124.30.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4PC17Z5vhWz3bVr for ; Thu, 9 Feb 2023 13:30:50 +1100 (AEDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R171e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045170;MF=jefflexu@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0VbDxLh3_1675909845; Received: from 30.221.133.91(mailfrom:jefflexu@linux.alibaba.com fp:SMTPD_---0VbDxLh3_1675909845) by smtp.aliyun-inc.com; Thu, 09 Feb 2023 10:30:46 +0800 Message-ID: <400c57ca-2804-a660-e543-42e15ac3b4a4@linux.alibaba.com> Date: Thu, 9 Feb 2023 10:30:45 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 1/2] erofs: update print symbols for various flags in trace Content-Language: en-US To: Gao Xiang , xiang@kernel.org, chao@kernel.org, linux-erofs@lists.ozlabs.org, huyue2@coolpad.com References: <20230208112915.6543-1-jefflexu@linux.alibaba.com> <416afeb8-4385-6d8a-4b35-2c75ffaa36cc@linux.alibaba.com> From: Jingbo Xu In-Reply-To: <416afeb8-4385-6d8a-4b35-2c75ffaa36cc@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: linux-erofs@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development of Linux EROFS file system List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org Errors-To: linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Sender: "Linux-erofs" On 2/9/23 10:29 AM, Gao Xiang wrote: > > > On 2023/2/8 19:29, Jingbo Xu wrote: >> As new flags introduced, the corresponding print symbols for trace are >> not added accordingly.  Add these missing print symbols for these flags. >> >> Also remove the print symbol for EROFS_GET_BLOCKS_RAW as it is going to >> be removed soon. >> >> Signed-off-by: Jingbo Xu >> --- >> v2: remove print symbol for EROFS_GET_BLOCKS_RAW >> --- >>   include/trace/events/erofs.h | 13 +++++++++---- >>   1 file changed, 9 insertions(+), 4 deletions(-) >> >> diff --git a/include/trace/events/erofs.h b/include/trace/events/erofs.h >> index e095d36db939..cf4a0d28b178 100644 >> --- a/include/trace/events/erofs.h >> +++ b/include/trace/events/erofs.h >> @@ -19,12 +19,17 @@ struct erofs_map_blocks; >>           { 1,        "DIR" }) >>     #define show_map_flags(flags) __print_flags(flags, "|",    \ >> -    { EROFS_GET_BLOCKS_RAW,    "RAW" }) > > Should we remove this in the next patch? > Otherwise it looks good to me. > Okay I will update this in the next version. -- Thanks, Jingbo