From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CBC2CC0015E for ; Mon, 17 Jul 2023 16:17:13 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4R4S0839fxz2yVl for ; Tue, 18 Jul 2023 02:17:12 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.alibaba.com (client-ip=115.124.30.133; helo=out30-133.freemail.mail.aliyun.com; envelope-from=hsiangkao@linux.alibaba.com; receiver=lists.ozlabs.org) Received: from out30-133.freemail.mail.aliyun.com (out30-133.freemail.mail.aliyun.com [115.124.30.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4R4Rzz2vczz2yN8 for ; Tue, 18 Jul 2023 02:17:00 +1000 (AEST) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R571e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046059;MF=hsiangkao@linux.alibaba.com;NM=1;PH=DS;RN=5;SR=0;TI=SMTPD_---0VneLyKX_1689610607; Received: from 30.25.237.231(mailfrom:hsiangkao@linux.alibaba.com fp:SMTPD_---0VneLyKX_1689610607) by smtp.aliyun-inc.com; Tue, 18 Jul 2023 00:16:51 +0800 Message-ID: <548cb723-6bce-4360-75f3-b4ec822bbf2c@linux.alibaba.com> Date: Tue, 18 Jul 2023 00:16:46 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2] erofs: deprecate superblock checksum feature To: Jingbo Xu , chao@kernel.org, huyue2@coolpad.com, linux-erofs@lists.ozlabs.org References: <20230717112703.60130-1-jefflexu@linux.alibaba.com> From: Gao Xiang In-Reply-To: <20230717112703.60130-1-jefflexu@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: linux-erofs@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development of Linux EROFS file system List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org Errors-To: linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Sender: "Linux-erofs" On 2023/7/17 19:27, Jingbo Xu wrote: > Later we're going to try the self-contained image verification. > The current superblock checksum feature has quite limited > functionality, instead, merkle trees can provide better protection > for image integrity. > > xxhash is also used in the following xattr name filter feature. It is > redundant for one filesystem to rely on two hashing algorithms at the > same time. > > Since the superblock checksum is a compatible feature, just deprecate > it now. > > Signed-off-by: Jingbo Xu I tend to agree on this since it slightly impacts mount time too: Reviewed-by: Gao Xiang Thanks, Gao Xiang