From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ED509C433FE for ; Fri, 14 Oct 2022 06:33:26 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Mpc5x4bnhz3cBR for ; Fri, 14 Oct 2022 17:33:25 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.alibaba.com (client-ip=115.124.30.44; helo=out30-44.freemail.mail.aliyun.com; envelope-from=jefflexu@linux.alibaba.com; receiver=) Received: from out30-44.freemail.mail.aliyun.com (out30-44.freemail.mail.aliyun.com [115.124.30.44]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Mpc5t4ZQ9z2xKV for ; Fri, 14 Oct 2022 17:33:22 +1100 (AEDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R521e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045192;MF=jefflexu@linux.alibaba.com;NM=1;PH=DS;RN=9;SR=0;TI=SMTPD_---0VS6Wv3A_1665729197; Received: from 30.221.130.30(mailfrom:jefflexu@linux.alibaba.com fp:SMTPD_---0VS6Wv3A_1665729197) by smtp.aliyun-inc.com; Fri, 14 Oct 2022 14:33:18 +0800 Message-ID: <60a05006-0052-c5eb-8f53-e1ce9ab26142@linux.alibaba.com> Date: Fri, 14 Oct 2022 14:33:17 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH V2 5/5] cachefiles: add restore command to recover inflight ondemand read requests Content-Language: en-US To: Jia Zhu , dhowells@redhat.com, xiang@kernel.org References: <20221014030745.25748-1-zhujia.zj@bytedance.com> <20221014030745.25748-6-zhujia.zj@bytedance.com> From: JeffleXu In-Reply-To: <20221014030745.25748-6-zhujia.zj@bytedance.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: linux-erofs@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development of Linux EROFS file system List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-cachefs@redhat.com, linux-fsdevel@vger.kernel.org, Gao Xiang , linux-erofs@lists.ozlabs.org, yinxin.x@bytedance.com Errors-To: linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Sender: "Linux-erofs" On 10/14/22 11:07 AM, Jia Zhu wrote: > Previously, in ondemand read scenario, if the anonymous fd was closed by > user daemon, inflight and subsequent read requests would return EIO. > As long as the device connection is not released, user daemon can hold > and restore inflight requests by setting the request flag to > CACHEFILES_REQ_NEW. > > Suggested-by: Gao Xiang > Signed-off-by: Jia Zhu > Signed-off-by: Xin Yin LGTM. Reviewed-by: Jingbo Xu -- Thanks, Jingbo