From: Markus Elfring <Markus.Elfring@web.de>
To: Gao Xiang <hsiangkao@linux.alibaba.com>,
linux-erofs@lists.ozlabs.org, kernel-janitors@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] erofs: simplify z_erofs_transform_plain()
Date: Tue, 27 Jun 2023 20:55:07 +0200 [thread overview]
Message-ID: <63f626ad-276d-6daf-541d-c2d877eb0c19@web.de> (raw)
In-Reply-To: <20230627161240.331-2-hsiangkao@linux.alibaba.com>
> Use memcpy_to_page() instead of open-coding them.
>
> In addition, add a missing flush_dcache_page() even though …
Does such a wording really fit to the known requirement “Solve only one problem per patch.”?
See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.4#n81
How do you think about to add the tag “Fixes”?
Regards,
Markus
next prev parent reply other threads:[~2023-06-27 18:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-27 16:12 [PATCH 1/2] erofs: get rid of the remaining kmap_atomic() Gao Xiang
2023-06-27 16:12 ` [PATCH 2/2] erofs: simplify z_erofs_transform_plain() Gao Xiang
2023-06-27 18:55 ` Markus Elfring [this message]
2023-06-28 6:38 ` Yue Hu
2023-07-11 15:28 ` Chao Yu
2023-06-27 18:44 ` [PATCH 1/2] erofs: get rid of the remaining kmap_atomic() Markus Elfring
2023-06-28 7:57 ` Yue Hu
2023-07-11 15:26 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63f626ad-276d-6daf-541d-c2d877eb0c19@web.de \
--to=markus.elfring@web.de \
--cc=hsiangkao@linux.alibaba.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox