From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 048A7C001B0 for ; Sun, 23 Jul 2023 13:28:34 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4R83ym5Jhtz30M1 for ; Sun, 23 Jul 2023 23:28:32 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.alibaba.com (client-ip=115.124.30.97; helo=out30-97.freemail.mail.aliyun.com; envelope-from=hsiangkao@linux.alibaba.com; receiver=lists.ozlabs.org) Received: from out30-97.freemail.mail.aliyun.com (out30-97.freemail.mail.aliyun.com [115.124.30.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4R83yc5rXZz2xJN for ; Sun, 23 Jul 2023 23:28:23 +1000 (AEST) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R191e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045170;MF=hsiangkao@linux.alibaba.com;NM=1;PH=DS;RN=5;SR=0;TI=SMTPD_---0Vo-PEBH_1690118895; Received: from 192.168.3.2(mailfrom:hsiangkao@linux.alibaba.com fp:SMTPD_---0Vo-PEBH_1690118895) by smtp.aliyun-inc.com; Sun, 23 Jul 2023 21:28:18 +0800 Message-ID: <6aa8bf9c-4feb-7dbe-4ddf-a42d9b19d3cb@linux.alibaba.com> Date: Sun, 23 Jul 2023 21:28:14 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v6 2/2] erofs: boost negative xattr lookup with bloom filter To: Jingbo Xu , chao@kernel.org, huyue2@coolpad.com, linux-erofs@lists.ozlabs.org References: <20230722094538.11754-1-jefflexu@linux.alibaba.com> <20230722094538.11754-3-jefflexu@linux.alibaba.com> From: Gao Xiang In-Reply-To: <20230722094538.11754-3-jefflexu@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: linux-erofs@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development of Linux EROFS file system List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alexl@redhat.com Errors-To: linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Sender: "Linux-erofs" On 2023/7/22 17:45, Jingbo Xu wrote: > Optimise the negative xattr lookup with bloom filter. > > The bit value for the bloom filter map has a reverse semantics for > compatibility. That is, the bit value of 0 indicates existence, while > the bit value of 1 indicates the absence of corresponding xattr. > > The initial version is _only_ enabled when xattr_filter_reserved is > zero. The filter map internals may change in the future, in which case > the reserved flag will be set non-zero and we don't need bothering the > compatible bits again at that time. For now disable the optimization if > this reserved flag is non-zero. > > Signed-off-by: Jingbo Xu Reviewed-by: Gao Xiang Thanks, Gao Xiang