Re: [PATCH v2] erofs-utils: lib: fix potential NULL pointer dereference in docker_config.c

[Lucas Karpinski <lkarpinski@nvidia.com>]

On 2026-03-18 10:06 a.m., Lucas Karpinski wrote:
> On 2026-03-16 4:53 a.m., lasyaprathipati@gmail.com wrote:
>> From: Sri Lasya <lasyaprathipati@gmail.com>
>>
>> ---
>>  lib/remotes/docker_config.c | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/lib/remotes/docker_config.c b/lib/remotes/docker_config.c
>> index b346ee8..6401c1b 100644
>> --- a/lib/remotes/docker_config.c
>> +++ b/lib/remotes/docker_config.c
>> @@ -202,8 +202,10 @@ int erofs_docker_config_lookup(const char *registry,
>>  		}
>>  
>>  		entry = json_object_iter_peek_value(&it);
>> -                if (!entry)
>> +                if (!entry) {
>> +			json_object_iter_next(&it);
>>  			continue;
>> +		}
>>  		if (json_object_object_get_ex(entry, "auth", &auth_field)) {
>>  			b64 = json_object_get_string(auth_field);
>>  			if (b64 && *b64) {
> There's still a tab issue as Gao mentioned in v1. This looks like a diff
> from your v1 to your v2 patch. Similarly, you also dropped your
> Signed-Off and are now using a From.
> 
> Lastly, you submitted another patch just yesterday that includes this
> change in addition to other changes. It is very difficult to follow what
> you're doing.

One correction, no tab issue anymore.