From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43B1AC3A5A6 for ; Tue, 27 Aug 2019 14:57:40 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BB5EC20828 for ; Tue, 27 Aug 2019 14:57:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.ozlabs.org header.i=@lists.ozlabs.org header.b="lCu1u/7N"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=android.com header.i=@android.com header.b="mzwUwotH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BB5EC20828 Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=lists.ozlabs.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 46HsRj0Ds9zDqWm for ; Wed, 28 Aug 2019 00:57:37 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=lists.ozlabs.org; s=201707; t=1566917857; bh=Js7KMNWUS2PkBu/cPmkHtJLAz1KlqBCMFHppsXZaysc=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=lCu1u/7NvMHerQKgRAxbdh8dlVDsXyFaYDyDvENqfBwhsDihjEnGm6BPhpDsaK/J7 u5XXFpkgaqWrhOjhHbNWxJK9pbJJUxuVqqPh4SnXFQ8TYDOu7bd70/hEQajZAXE2bH GogzHCqv5HEElGdfdoZaQyU/9pkqQM+dLaKFK+uLJEu13bxdCHFHyb1wPVGxAkf9nx OkDy8ZoxVdsUBXvFu2TveQCpInp8yVqPYGeiU5vylFkq8qeuk+alsbpnj4S7ygSSEM tKfCD6HGXkkqpNb9se8jxhoGos0qDcKyVt0csjk3geoE8Z1+nj3xAMJECfpbqBSujB 0J8daywV6+9EA== Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=android.com (client-ip=2607:f8b0:4864:20::444; helo=mail-pf1-x444.google.com; envelope-from=salyzyn@android.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=reject dis=none) header.from=android.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=android.com header.i=@android.com header.b="mzwUwotH"; dkim-atps=neutral Received: from mail-pf1-x444.google.com (mail-pf1-x444.google.com [IPv6:2607:f8b0:4864:20::444]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 46HsNW0mxXzDqfy for ; Wed, 28 Aug 2019 00:54:50 +1000 (AEST) Received: by mail-pf1-x444.google.com with SMTP id w26so14250884pfq.12 for ; Tue, 27 Aug 2019 07:54:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=android.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=J0PyrXbgy2rQbHf32v3WQfO8h7H5WwZ0x8ImHOimCWs=; b=mzwUwotHCHLyC8kvJQKX2qfkclXUibOZVKlCSAmub430gCcW4lmMANVBjk4ZJn37Mz lmwqaekfvRnk91fWBTPe9MdR6DNIOZYbn1kKQlCtB2EIRUw9eVK89gLHZxbOnS+BoN9O z/e+lec1c3V+A/cevmzn6YhUNeV1qLcxR5P5ZMIEm0QeC99vQIqrptkzAecOAow3P+WG qTbXtfhvLGsZsqUEkNrN67J91EYh7XB3OB1b7OQP26/5Ffe7WcOAgQyPgjx4Kr7W8Oc+ UwQjFeNzqy6bSLsp44PwvDCnhYQ/gCS2wppnuYUD4QcGMN8OxcAFpKCWSwZ+EWDarzDN vqDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=J0PyrXbgy2rQbHf32v3WQfO8h7H5WwZ0x8ImHOimCWs=; b=tdHong1yKH1GfQ2zzWg8Am710PdBX7xeb56XYwuppmh+r5D5Bsm/LNusiVIMggKxj7 qpz1qy6Oeu1jvQt5X1VL8u7iiMmHMz8TqTdtFvF/4JMUqBsSRelMtgjWzVdQCfxdBEip sRqnGLsHWjFO6P0SRgBqeMpGusUknI9r9cBOuZe6299C4XrZ/aRCbKySsG2ybC+YNzBr 74eAz0rPyB29+cfDuZNFVf8sYLPBNgCymP8wToYE85/OzsVkBW91XDQPIwdxYuBmetaN ulAWAriO8uTVHzfnpfYNLuAUIaOJqLXN57uXcr3fsojzTSe43jAgT9NQs/4q77V01oto qtPg== X-Gm-Message-State: APjAAAVZoVYKqVkMaeUQ22tFkzRbZzuNd6fyXMOVfKU6CLsZe7ruh0zC muLNQ6av4wP6WwNGll6z/5pGYg== X-Google-Smtp-Source: APXvYqwBoH7/mHEw1qHJ4C0pvUdOnWf9w3cFM7T1JRRoXNt8gEzBDpTDPLau8WREch+lyRDJT+u4BA== X-Received: by 2002:a65:6891:: with SMTP id e17mr20940506pgt.305.1566917687986; Tue, 27 Aug 2019 07:54:47 -0700 (PDT) Received: from nebulus.mtv.corp.google.com ([2620:15c:211:200:5404:91ba:59dc:9400]) by smtp.googlemail.com with ESMTPSA id s125sm30946505pfc.133.2019.08.27.07.54.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Aug 2019 07:54:47 -0700 (PDT) Subject: Re: [PATCH v7] Add flags option to get xattr method paired to __vfs_getxattr To: Jan Kara References: <20190820180716.129882-1-salyzyn@android.com> <20190827141952.GB10098@quack2.suse.cz> Message-ID: <8468b22d-05b7-47d3-eb93-2c71dafea3ee@android.com> Date: Tue, 27 Aug 2019 07:54:44 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190827141952.GB10098@quack2.suse.cz> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-BeenThere: linux-erofs@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development of Linux EROFS file system List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mark Salyzyn via Linux-erofs Reply-To: Mark Salyzyn Cc: Latchesar Ionkov , Eric Sandeen , Mike Marshall , linux-xfs@vger.kernel.org, James Morris , devel@lists.orangefs.org, Eric Van Hensbergen , Joel Becker , Trond Myklebust , Mathieu Malaterre , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Jan Kara , Casey Schaufler , Andrew Morton , Dave Kleikamp , linux-doc@vger.kernel.org, Jeff Layton , Mimi Zohar , "David S. Miller" , linux-cifs@vger.kernel.org, Paul Moore , "Darrick J. Wong" , Hugh Dickins , kernel-team@android.com, selinux@vger.kernel.org, Brian Foster , reiserfs-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Jaegeuk Kim , Theodore Ts'o , Miklos Szeredi , linux-f2fs-devel@lists.sourceforge.net, Benjamin Coddington , linux-integrity@vger.kernel.org, Martin Brandenburg , Chris Mason , linux-mtd@lists.infradead.org, linux-afs@lists.infradead.org, Jonathan Corbet , Vyacheslav Dubeyko , Allison Henderson , Ilya Dryomov , linux-ext4@vger.kernel.org, Stephen Smalley , Serge Hallyn , Eric Paris , ceph-devel@vger.kernel.org, linux-nfs@vger.kernel.org, Joseph Qi , samba-technical@lists.samba.org, Steve French , Bob Peterson , Tejun Heo , linux-erofs@lists.ozlabs.org, Anna Schumaker , ocfs2-devel@oss.oracle.com, jfs-discussion@lists.sourceforge.net, Eric Biggers , Dominique Martinet , Jeff Mahoney , linux-unionfs@vger.kernel.org, David Howells , linux-mm@kvack.org, Andreas Dilger , devel@driverdev.osuosl.org, "J. Bruce Fields" , Andreas Gruenbacher , Sage Weil , Richard Weinberger , Mark Fasheh , linux-security-module@vger.kernel.org, cluster-devel@redhat.com, v9fs-developer@lists.sourceforge.net, Bharath Vedartham , Jann Horn , ecryptfs@vger.kernel.org, Josef Bacik , Dave Chinner , David Sterba , Artem Bityutskiy , netdev@vger.kernel.org, Adrian Hunter , stable@vger.kernel.org, Tyler Hicks , =?UTF-8?Q?Ernesto_A=2e_Fern=c3=a1ndez?= , Phillip Lougher , David Woodhouse , linux-btrfs@vger.kernel.org, Alexander Viro Errors-To: linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Sender: "Linux-erofs" On 8/27/19 7:19 AM, Jan Kara wrote: > On Tue 20-08-19 11:06:48, Mark Salyzyn wrote: >> diff --git a/Documentation/filesystems/Locking b/Documentation/filesystems/Locking >> index 204dd3ea36bb..e2687f21c7d6 100644 >> --- a/Documentation/filesystems/Locking >> +++ b/Documentation/filesystems/Locking >> @@ -101,12 +101,10 @@ of the locking scheme for directory operations. >> ----------------------- xattr_handler operations ----------------------- >> prototypes: >> bool (*list)(struct dentry *dentry); >> - int (*get)(const struct xattr_handler *handler, struct dentry *dentry, >> - struct inode *inode, const char *name, void *buffer, >> - size_t size); >> - int (*set)(const struct xattr_handler *handler, struct dentry *dentry, >> - struct inode *inode, const char *name, const void *buffer, >> - size_t size, int flags); >> + int (*get)(const struct xattr_handler *handler, >> + struct xattr_gs_flags); >> + int (*set)(const struct xattr_handler *handler, >> + struct xattr_gs_flags); > The prototype here is really "struct xattr_gs_flags *args", isn't it? > Otherwise feel free to add: > > Reviewed-by: Jan Kara > > for the ext2, ext4, ocfs2, reiserfs, and the generic fs/* bits. > > Honza Thanks and good catch, will respin with a fix to the documentation shortly. -- Mark