From: Gao Xiang <hsiangkao@linux.alibaba.com>
To: "zhaoyifan (H)" <zhaoyifan28@huawei.com>,
linux-erofs@lists.ozlabs.org, guoxuenan@huawei.com,
zhukeqian1@huawei.com
Subject: Re: [PATCH] erofs-utils: build: link tools with liberofs dependencies
Date: Mon, 8 Jun 2026 13:46:50 +0800 [thread overview]
Message-ID: <9ddb3fab-e5b1-4dec-a73b-814e833e208d@linux.alibaba.com> (raw)
In-Reply-To: <1c8489d6-c55b-426d-b965-b6b96caa616f@huawei.com>
On 2026/6/7 19:29, zhaoyifan (H) wrote:
>
> On 2026/6/3 22:36, Gao Xiang wrote:
...
>>> +])
>> Although I admit that I'm not super happy with this approach, but it
>> seems that we have to do like this.
>>
>> My only question here is that why ${libxxhash_LIBS}, ${libxml2_LIBS}
>> and ${libnl3_LIBS} cannot be appended directly to LIBEROFS_LIBS as
>> others.
>
> As these flags were conditionally appended to liberofs_la_LDFLAGS in the original lib/Makefile.am code path.
Can we append them into LIBEROFS_LIBS directly?
Thanks,
Gao Xiang
>
>
> Thanks,
>
> Yifan
>
>> But I think it's fine to guard `-lpthread` with enable_multithreading
>> tho.
>>
>> Thanks,
>> Gao Xiang
>>
next prev parent reply other threads:[~2026-06-08 5:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-29 7:17 [PATCH] erofs-utils: build: link tools with liberofs dependencies Yifan Zhao
2026-06-01 12:52 ` Guo Xuenan
2026-06-03 14:36 ` Gao Xiang
2026-06-07 11:29 ` zhaoyifan (H)
2026-06-08 5:46 ` Gao Xiang [this message]
2026-06-09 9:04 ` [PATCH v2] " Yifan Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ddb3fab-e5b1-4dec-a73b-814e833e208d@linux.alibaba.com \
--to=hsiangkao@linux.alibaba.com \
--cc=guoxuenan@huawei.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=zhaoyifan28@huawei.com \
--cc=zhukeqian1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox