From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95132C433F5 for ; Mon, 1 Nov 2021 16:21:38 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D92136113D for ; Mon, 1 Nov 2021 16:21:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D92136113D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4HjdZm3YQ8z2yJP for ; Tue, 2 Nov 2021 03:21:36 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Jb2ieF+U; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Jb2ieF+U; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=redhat.com (client-ip=170.10.133.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=snitzer@redhat.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Jb2ieF+U; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Jb2ieF+U; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4HjdZh2Q35z2xRn for ; Tue, 2 Nov 2021 03:21:32 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635783689; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=E9idZ9g7Qiy202IHm24WOcqzjkMEWV4Amwu/3bidfKY=; b=Jb2ieF+UJCAXaI4awu80SUFZWF1CkD+S/ZJK/qbpHthY8oUap767smt5XzxZrVboica49v Gc/NLA+cN/NPFJyzzwDixs9cL1vW5tpevJ1qXmdcl2xVTclP6wi6hIsKzEOnYopmlUHAik 6/rk9NCN9qyolMzY00bExSCWPb1mljU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635783689; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=E9idZ9g7Qiy202IHm24WOcqzjkMEWV4Amwu/3bidfKY=; b=Jb2ieF+UJCAXaI4awu80SUFZWF1CkD+S/ZJK/qbpHthY8oUap767smt5XzxZrVboica49v Gc/NLA+cN/NPFJyzzwDixs9cL1vW5tpevJ1qXmdcl2xVTclP6wi6hIsKzEOnYopmlUHAik 6/rk9NCN9qyolMzY00bExSCWPb1mljU= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-316-j19-GSIJN0GraIHtYWhPlg-1; Mon, 01 Nov 2021 12:21:28 -0400 X-MC-Unique: j19-GSIJN0GraIHtYWhPlg-1 Received: by mail-qv1-f72.google.com with SMTP id jo4-20020a056214500400b003a5cb094fb8so6090430qvb.22 for ; Mon, 01 Nov 2021 09:21:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=E9idZ9g7Qiy202IHm24WOcqzjkMEWV4Amwu/3bidfKY=; b=uWYbMxA05mPQyY6FMlGAnRvZ2QlPTvP540VhHgyY3MdevtkUgyc9nXXjKhFlgal2TD abyFG6k5PfxHjQdDbmHtKL8A70mfoAMKAI8arwxv2X+l80qkcaZPXyrvQ0OSkPsMWAwz /CJTtsKNHFWGZCXov9A5q9D0iv8OvKbldpbn+yFP8FNvwa66vrnUcZ1s31/dbKk5f1bb n+HHREl5DnJvFCa0GzZEY49uVXnBx+F7TK5vqgipdfBF4GzEz84fenpU5eBHrbiATr6T tKHLX6BSR+zxdUyvl0Dz4ULjOL7bcM8di+pXriVBuamsO+LIrDLTU1SDhXbjyxRWImVi kkkA== X-Gm-Message-State: AOAM532pvVJsnEjc4zU2Gq4xg1WtrzcZH7KmhhVrOqKiMQF35v4U7hfT EEq3tSWbGEe3wcMwA92/Te7Vl8UmkewfMmUHp+wZCrue+KMgLGu7XT5k/y4pFzznUBjDI6EXf53 q5adNtJXK2+NKS3R85dHFw7Q= X-Received: by 2002:ac8:7d04:: with SMTP id g4mr30472029qtb.183.1635783688228; Mon, 01 Nov 2021 09:21:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwXhGf8N2V91WU2Co6WJDyYs4GGgkn9JXnS/oEwWuG4J0RZNo7zMUQJUBh2KgjI9ZclpX5QJg== X-Received: by 2002:ac8:7d04:: with SMTP id g4mr30472009qtb.183.1635783688071; Mon, 01 Nov 2021 09:21:28 -0700 (PDT) Received: from localhost (pool-68-160-176-52.bstnma.fios.verizon.net. [68.160.176.52]) by smtp.gmail.com with ESMTPSA id bj3sm2670847qkb.75.2021.11.01.09.21.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Nov 2021 09:21:27 -0700 (PDT) Date: Mon, 1 Nov 2021 12:21:26 -0400 From: Mike Snitzer To: Dan Williams Subject: Re: [PATCH 10/11] dm-stripe: add a stripe_dax_pgoff helper Message-ID: References: <20211018044054.1779424-1-hch@lst.de> <20211018044054.1779424-11-hch@lst.de> MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=snitzer@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-BeenThere: linux-erofs@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development of Linux EROFS file system List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux NVDIMM , linux-s390 , linux-erofs@lists.ozlabs.org, virtualization@lists.linux-foundation.org, linux-xfs , device-mapper development , linux-fsdevel , linux-ext4 , Ira Weiny , Christoph Hellwig Errors-To: linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Sender: "Linux-erofs" On Wed, Oct 27 2021 at 9:41P -0400, Dan Williams wrote: > On Sun, Oct 17, 2021 at 9:41 PM Christoph Hellwig wrote: > > > > Add a helper to perform the entire remapping for DAX accesses. This > > helper open codes bdev_dax_pgoff given that the alignment checks have > > already been done by the submitting file system and don't need to be > > repeated. > > Again, looks good. Kind of embarrassing when the open-coded version is > less LOC than using the helper. > > Mike, ack? Acked-by: Mike Snitzer