Linux-EROFS Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Gao Xiang <xiang@kernel.org>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: linux-erofs@lists.ozlabs.org
Subject: Re: [PATCH] Add --disable-werror
Date: Thu, 21 Apr 2022 08:03:22 +0800	[thread overview]
Message-ID: <YmCfSvAac8KCgl50@debian> (raw)
In-Reply-To: <20220420221018.1396105-1-fontaine.fabrice@gmail.com>

On Thu, Apr 21, 2022 at 12:10:18AM +0200, Fabrice Fontaine wrote:
> Add an option to disable -Werror to fix the following build failure with
> gcc 4.8 raised since version 1.4 and
> https://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs-utils.git/commit/?id=cf8be8a4352a5df3b3acf545af289cb47faa6de0:
> 
> In file included from /home/buildroot/autobuild/instance-0/output-1/host/arm-buildroot-linux-gnueabi/sysroot/usr/include/string.h:636:0,
>                  from ../include/erofs/internal.h:242,
>                  from ../include/erofs/inode.h:11,
>                  from main.c:12:
> In function 'memset',
>     inlined from 'erofsdump_filetype_distribution.constprop.2' at main.c:583:9:
> /home/buildroot/autobuild/instance-0/output-1/host/arm-buildroot-linux-gnueabi/sysroot/usr/include/bits/string3.h:81:30: error: call to '__warn_memset_zero_len' declared with attribute warning: memset used with constant zero length parameter; this could be due to transposed parameters [-Werror]
>        __warn_memset_zero_len ();
>                               ^
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/4c776ec935bbb016231b6701471887a7c9ea79e9
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Thanks, applied with some minor commit message changes. And also
disable -Werror by default, since it's somewhat annoying on
(almost) every release due to various configuration combinations
which I couldn't cover all.

Thanks,
Gao Xiang

      reply	other threads:[~2022-04-21  0:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-20 22:10 [PATCH] Add --disable-werror Fabrice Fontaine
2022-04-21  0:03 ` Gao Xiang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YmCfSvAac8KCgl50@debian \
    --to=xiang@kernel.org \
    --cc=fontaine.fabrice@gmail.com \
    --cc=linux-erofs@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox