Linux-EROFS Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Gao Xiang <xiang@kernel.org>
To: Naoto Yamaguchi <wata2ki@gmail.com>
Cc: Naoto Yamaguchi <naoto.yamaguchi@aisin.co.jp>,
	linux-erofs@lists.ozlabs.org
Subject: Re: [PATCH] erofs-utils: mkfs: Add volume-name setting support
Date: Wed, 5 Oct 2022 00:33:00 +0800	[thread overview]
Message-ID: <YzxgPKoi9Q1scK3N@debian> (raw)
In-Reply-To: <CABBJnRa6S87f9uwuUEfR55rKHwnhkpDVtfPvX0tcoZWc_2vgow@mail.gmail.com>

On Wed, Oct 05, 2022 at 01:25:48AM +0900, Naoto Yamaguchi wrote:
> Hi Gao
> 
> Thank you feedback!
> 
> >1) How about following mke2fs by using "-L volume-label" ?
> >https://www.man7.org/linux/man-pages/man8/mke2fs.8.html
> 
> The mkfs.extX is using "-L volume-label".
> The mkfs.vfat is using "-n volume-name".
> I think both better.
> You commented to "-L" is more better, I will change it.

Yeah, I tend to follow mke2fs if it has the similar
function if possible, since it's more widely used :)

> 
> >2) If possible, how about adding a kernel ioctl for this if you have more interest?
> >I mean FS_IOC_GETFSLABEL.
> 
> It's interesting feature.  I will try to work it.
> 

Thanks a lot! Yet that is not urgent since 6.1 features are
already fixed, it needs to be landed in 6.2...

Thanks,
Gao Xiang

> Thanks,
> Naoto Yamaguchi.
> a member of Automotive Grade Linux Instrument Cluster EG.
> 

  reply	other threads:[~2022-10-04 16:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-04 16:02 [PATCH] erofs-utils: mkfs: Add volume-name setting support Naoto Yamaguchi
2022-10-04 16:15 ` Gao Xiang
2022-10-04 16:25   ` Naoto Yamaguchi
2022-10-04 16:33     ` Gao Xiang [this message]
2022-10-04 16:43       ` Naoto Yamaguchi
2022-10-04 16:49         ` Gao Xiang
2022-10-04 17:01           ` [PATCH v3] " Naoto Yamaguchi
2022-10-04 17:04           ` [PATCH] " Naoto Yamaguchi
2022-10-04 17:54             ` Gao Xiang
2022-10-04 21:33               ` Naoto Yamaguchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YzxgPKoi9Q1scK3N@debian \
    --to=xiang@kernel.org \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=naoto.yamaguchi@aisin.co.jp \
    --cc=wata2ki@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox